ipjohnson / grace.mvc Goto Github PK

When you make a lookup for a type with Func injected on the constructor, it can mess up the lookup for request-scoped types.

Simple repro on MVC5:
https://drive.google.com/open?id=1StgddYLxUshj0IknbY2zKGo1wc6MUjO3

In this case, the fact that MyMapper is resolved in Global.asax.cs messes up the lookup for IPerRequestThing later on.

In example

https://drive.google.com/open?id=1StgddYLxUshj0IknbY2zKGo1wc6MUjO3

If you comment out the crashing line in Global.asax.cs, you still end up getting the same RequestContext object every request, even though it is registered like this on every request:

Ioc.Container.Configure(b =>
{
	b.ExportInstance(new RequestContext()).As<IRequestContext>().Lifestyle.SingletonPerRequest();
});

If you add in a line to print out the hash code for the RequestContext inside PerRequestThing, it always comes up with the same one.

Grace 7.0.0 is doing away with the custom disposal scope provider in favor of using a custom disposal scope expression creator.

To accommodate this we need to implement a new creator and get rid of the disposal scope provider.