ipenguin / crochetcharts Goto Github PK

Color can not be set on a group. Each internal symbol in a group has to be selected to recolor.
This makes recoloring groups very time consuming. Groups are super useful.

To make the tool work the code in cell.cpp needs to check if item is grouped then iterate over children.

Code is here:

void Cell::setBgColor(QColor c)
{
    if (mBgColor != c) {
        QString old = "";
        if (mBgColor.isValid())
            old = mBgColor.name();
        mBgColor = c;
        emit colorChanged(old, c.name());
        update();
    }
}

void Cell::setColor(QColor c)
{

    if(mColor != c) {
        QString old = "";
        if(mColor.isValid())
            old = mColor.name();
        mColor = c;

        QSvgRenderer *r = stitch()->renderSvg(c);
        if(r)
            setSharedRenderer(r);

        emit colorChanged(old, c.name());
        update();
    }

}

Check is bool Cell::isGrouped()

Many people seem to have added their own stitches (with varying degrees of success) to the stitch library. Works me for me too BTW and I'd like to document the process for others to follow. Should I use the Wiki ?

What do you recommend as the best way for users to contribute sets that might end up in the product when a new compile is made.
I can see crochet.xml has the list of stitches from that directory. so pull requests adding entries to that file and new files in stitches is legit. but currently no pull request submitted even though there are two forks showing in the network...

But what about the middle ground (requiring no new compilation) where sets could be collected.
Could a new git or sub(?) git be made where people could add new sets and thereby download those sets to manually add to their local copies...

What do you think ?

When I go to change the stitch on selected stitches, the stitches on the whole grid change.

Selected stitches were copied and pasted from unselected stitches.

When I cut the selected stitches from one layer and put them on a second and select only that second layer, I try to change the stitches, and all stitches on both layers change.

Can this be changed so that any stitches I select will change to the stitch I want?

If an indicator is saved with a CarriageReturn/LineFeed embedded in it appears like this in the .pattern xml file:

<indicator>
            <x>115.608</x>
            <y>-98.4189</y>
            <text>3. Pickup prior loop again.
    sc through next stitch.</text>

However on reload the carriage return is being ignored on reading and the indicator shows as a single line of text.

Note the character at the end of the line is a LineFeed. This is the same as every other line. so no CarriageReturn is actually in file.

Not sure if correct solution is in encoding to file, or in reading from file.

If the category was shown in the stitches pane in the main window then we could sort filtered stitches by category.
This would allow users to bring these stitches to the top of the list.
This would be super useful when we have many more stitches.

The file to edit is mainwindow.ui
The section in the file is labelled:
<widget class="QDockWidget" name="allStitchesDock">

Under here we currently have widget <widget class="QTreeView" name="allStitches">
In addition to the stitch name and icon, please also add category.

(Because we can add categories using the hidden xml import mechanism in the configuration file)

new stitches created in (say) Inkscape 0.92.4 show very small icons when loaded.

Problem is traced to code in stitchset.cpp
function StitchSet::data

    if(role == Qt::DisplayRole || role == Qt::EditRole) {
        switch(index.column()) {
            case Stitch::Name:
                return QVariant(s->name());
            case Stitch::Icon: {
                if(role == Qt::DisplayRole) {
                    return QVariant(QSize(s->width(), s->height()));
                } else {
                    return QVariant(s->file());
                }
            }

in originally authored (inkscape 0.48) files the width and height were plain integers (pixels was assumed) and a viewbox was not used. E.g. in sts63.svg

width="38"
height="96"

in Inkscape 0.92 etc a viewbox is used and width and height are in units. E.g.

viewBox="0 0 9 10"
height="10mm"
width="9mm"

So the display needs to use a different size metric so the icons can be seen larger.
Perhaps:

• interpret the dimensioned units, or
• an integer multiplier of the extracted numbers (but units can be mm,in,px,picas,...) (Pixels now 96dpi FYI)