ionicabizau / gridly Goto Github PK

would be nice to have a litte more info about which browsers are supported, e.g. which of the old flexbox syntaxes are in and which are not? Thanks!

While I love the concept of Gridly, using this on client sites has been getting me hollered at for small bugs with IE11. I get we can't support every version of IE, but IE11 touts it supports flexbox. Poorly though.

From my experience I've learned that it doesn't use the default settings of 'flex:1' like the rest of the browsers. So you must be more explicit for it to work properly. Also adding the prefixed versions of the props can't hurt. I did read your 'guidelines' for contributing, but seemed like overkill for a project which literally has two lines of (compressed) CSS.

.row{display:-ms-flexbox;display:-webkit-flex;display:flex;}
.col{-ms-flex-grow:1;-webkit-flex-grow:1;flex-grow:1}

@media(max-width:48em){
.row{-ms-flex-direction: column;-webkit-flex-direction: column;flex-direction:column;}
.col{flex:0 0 auto}
}

Hi,

I'm about to use this library in eme, but I find uglifycss was duplicated in package.json

See https://github.com/IonicaBizau/gridly/blob/gh-pages/package.json#L173

Noticed the links to the zip downloads on your github.io homepage are dead (at least for me, just now).

Also a question, does Gridly support nesting?

Spotted in Safari OS X 9.0.1 on OS X. On narrower views (below 48em, I believe), the grid collapses vertically, creating a visual bug. This is caused by how Safari handles flex: 0 0 100%. Setting this to flex: 0 0 auto should fix this behavior, but more cross-browser testing is needed since Chrome, Firefox and others may treat this differently (although I believe my fix should work, so do test it out). flex-basis: 100% is the issue here. Note that 100% works for horizontal (row) but fails for vertical (column) flex layouts in Safari. auto (the default value for flex-basis) negates the issue for either flex-direction.

I have run into this issue on multiple other sites. I've looked at the spec and I'm not yet entirely sure whether Safari has it right or wrong.

Let me know if you want more testing or a PR.

It will be great you may considerate to add your production file to some CDN server.
Great job!

How can i add a 20px gutter to the columns?
Like the bootstrap one