invoca / magic_frozen_string_literal Goto Github PK

Pretty much be able to undo the changes.

Many rubyists will install gems into a project local subdirectory like vendor/bundle with bundler. This is very useful when users don't have permissions to muck with system installed gems. Unfortunately this gem considers vendor/bundle as part of the application repo and attempts to add the comment to all gem files.

A solution could be to always ignore vendor/bundle, but a more general solution would be to allow an --exclude to be passed from the CLI.

A workaround is to, 1) rm -rf vendor/bundle 2) magic_frozen_string_literal 3) reinstall the local gems.

Feel free to categorize as wontfix. The code is simple enough that it might not be worth adding many features.

Per this thread from 3 months ago:

I consider this for years. I REALLY like the idea but I am sure introducing this could cause HUGE compatibility issue, even bigger than Ruby 1.9. So I officially abandon making frozen-string-literals default (for Ruby3).
This does not mean we are going to remove the frozen-string-literal feature that can be specified by magic comments.
Matz.

Maybe the README should be updated given this.

Add an empty line after magic comments. from rubocop

Hi,

I use your magic_frozen_string_literal command on Windows and found that the command overrides newline code.

$ ruby -v
ruby 2.5.3p105 (2018-10-18 revision 65156) [x64-mingw32]

Before:

After:

I think that the command should not override newline code.

I want a slow transition
So I don't want to turn it on for every file in my projects at once
But I want a comment at a top so I remember to change it to true

# frozen_string_literal: false

Currently, Gemfile files have the comment added, but *.gempsec do not. They should as well.

I noticed belatedly that Rakefile and other similarly-named files do not get handled. I wonder if adding support for such files is desirable. I think for Rakefile it may be, but likely not worthwhile for other files.

I'm brainstorming about how to test performance of my apps before and after using the gem with Ruby 2.3. Has anyone done this and would like to share the results?

We had a couple files with a .rb extension that had a #! (shebang) at the top that were corrupted by the magic comment. It would probably be best if those files didn't have the .rb extension, but they did. The calling code was running them without a ruby in front. Without the #! at the top, they stopped working.

I have a js.erb file like this

//= require xxxx
var xxx = <%= XXX.to_json.html_safe %>

after running magic_frozen_string_literal, it become

<%# frozen_string_literal: true %>
//= require xxxx
var xxx = <%= XXX.to_json.html_safe %>

But the first line <%# frozen_string_literal: true %> seems to make //= require xxxx not working