Git Product home page Git Product logo

angular-toasty's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

angular-toasty's Issues

Toast hidden when called programatically

Whenever I call my toast from a function it's somehow not displayed, DOM also does not change. You can hear the sound though.

Only when it's called a second time it shows.

	function showToast(type, title, message) {
		toasty[type]({
			title: title,
			msg: message
		});
	}

	function checkExpired() {
		showToast("warning", "Warning", "Your session is about to expire. Click here to stay logged in!");
	}

setInterval(checkExpired, 5000);

When I call it from the ng-click directive in the view it works fine every time.

Request: Add type override

Please add a type override to the default toasty() function.

That way I can do something like this without creating 5 different functions:

  function showToast(type,title,message) {
    toasty({
      title: title,
      msg: message,
      sound: true,
      type: type
    });
  }

showToast("warning","Error: ","Something went wrong!");

Title doesn't center when no message

If there's no message body, the title still stays on top. Not sure how to check, could use the :empty check with CSS. Will look into it myself.

showClose parameter

In sourse code, defaul value showClose parameter set is true (constant toastyConfig), but it not working. If I don't set manual showClose in true, close button not shown. The same is not working toasty-container toasty-defaults attribute fo showClose parameter. Always default close button not showing.

Unable to get working with Browserify

Hi,
I tried to get angular-toasty working with browserify but browserify fails with warning.

Running "browserify:app" (browserify) task
>> Error: Cannot find module 'angular-toasty' from 'C:\Test\web-app\src\main\resources\public\app'
Warning: Error running grunt-browserify. Use --force to continue.

Any workarounds? Is this module supports to commonJS modules or modules that support by browserify?

Just showing plain text

I have a weird error all of the sudden. Toasty has been working fine, did not touch it but now it only shows the notification in plain text where the tags are inserted.

So there is no styling and it isn't placed at the bottom or top for example. Sounds familiar?

Unable to get it work with IE11

Hi, I have implemented the toasty as suggested in example and it not working in IE11. However, I was able to get it work on Firefox.

Is there something I have missed in configuring it properly. Please help.

Make it Themable

I love how simple this component is.

It would be nice if I could theme is easily, e.g. without having to override a bunch of CSS. The positioning styling could be split out from the content styling.

Update Angular version

It is causing dependency conflict with other libraries. Can this be updated to angular 1.5.8?

feature request: disable completely for testing

HI there,
do you provide any mocks or enabled=false feature so it can be disabled completely in protractor tests?

I figured out that using toasty in protractor tests leads to the element are not clickable errors because the toast just appears and I cannot click on the element underneath the toast... It would be cool to have such a feature to turn it off to avoid these issues.

Anyway,
thanks for a great job!

Cheers,
Andrej

Typescript error: file "is not under 'rootDir' when running tsc #2

{
"compilerOptions": {
"target": "es5",
"module": "system",
"moduleResolution": "node",
"sourceMap": true,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"removeComments": false,
"noImplicitAny": false,
"noEmitOnError": true,
"rootDir": "app",
"outDir": "../wwwroot/app/"

},
"compileOnSave": true,

"exclude": [
"node_modules",
"wwwroot/lib"

]
}

Toast hidden behind modal

[EDIT]
Found the problem. It plays the sound but when looking at the DOM through the Chrome DevTools I see no changes, when I close the modal however I do see the toast.... Except when I add another toast when the first one should still be there, then the DOM changes and I see a toast.


Somehow my Toasts suddenly started popping up behind the translucent modal backdrop. You cannot see them unless you close the modal.

I've tried adding this to CSS but that doesn't work either. Any idea?

toasty {
z-index: 1000000;
}

#toasty {
z-index: 1000000;
}

Position should allow centering

Currently position only allows 4 configurations.

  • position: 'bottom-right', // {string:bottom-right,bottom-left,top-right,top-left} The window position where the toast pops up

Is there any plans of adding 'bottom-center' and 'top-center'?

sound value always ignored

I'm using the latest version and I'm creating the toasty like this:

                            toasty.pop.success({
                                title: 'Your comment has been successfully added!',
                                sound: false,
                                showClose: false,
                                clickToClose: false,
                                timeout: 1500
                            });

I don't know why, but all the times it play the sound.

Is it a bug? What can I do to fix it?

Font loading is done via http

Roboto Google font is loaded via http, that can cause browser error in case site uses https.
Consider changing

http://fonts.gstatic.com/s/roboto/v15/zN7GBFwfMP4uA6AR0HCoLQ.ttf

to

//fonts.gstatic.com/s/roboto/v15/zN7GBFwfMP4uA6AR0HCoLQ.ttf 

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.