feds's People
Forkers
fabiaz84feds's Issues
Faulty slippage checks
feds/src/velo-fed/VeloFarmer.sol
Lines 110 to 120 in 45f3083
Should not assume half of dola to be sold, but rather sell for a proportionate amount to input. Maybe be hard to calculate.
feds/src/velo-fed/VeloFarmer.sol
Lines 127 to 133 in 45f3083
Should calculate expected amount of lpTokens given dola + usdc input value, and then check that this has been received. dolaAmountMin and usdcAmountMin can be set to 0.
feds/src/velo-fed/VeloFarmer.sol
Lines 138 to 140 in 45f3083
Won't function right now without a very high maxLoss param, but will work given above changes to the deposit function is implemented.
feds/src/velo-fed/VeloFarmer.sol
Lines 147 to 160 in 45f3083
Calculate optimistic value of LP tokens, then withdraw corresponding value to dolaAmount value.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.