inthepocket / cookie-though Goto Github PK

View Code? Open in Web Editor NEW

103.0 7.0 8.0 6.07 MB

🍪 Easy to use, minimal footprint cookie consent library. So delicious, you'll never need another library again 😄

Home Page: https://cookiethough.dev

License: MIT License

JavaScript 2.10% HTML 2.07% Shell 2.38% CSS 10.61% TypeScript 82.31% Ruby 0.53%

gdpr-consent gdpr-compliant cookie-consent

cookie-though's People

Contributors

Stargazers

Watchers

Forkers

dietr pechisworks alexmalus robrechtme amexio-kretz sotvorenniy level09 jeerawat

cookie-though's Issues

Discourage dark patterns

The default button in a cookie nagger should preferably be "Enable the strictly necessary" and not "Accept all".

The sample dialog has a darkish-pattern IMO. A user has to notice that "Customize" is a link. It needs to clicked first to see what the customizable options are. That makes for two extra clicks.

Incorrect aria-expanded attribute

Hi, I have a small accessibility improvement.

The element <div class="ct-collapse"> has an aria-expanded attribute. This attribute should be used on a control to indicate if its controlled elements are hidden or displayed.

So the <button class="ct-customization-button"> should have the aria-expanded attribute, and <div class="ct-collapse"> should have an aria-hidden attribute.

Google Lighthouse also indicates the current implementation is in violation with the specs.

Tag a cookie as essential

How could I attach to an specific cookie name that it belong to the essentials cookies?

Add extra CSS variables

Is it possible to add some more CSS variables such as:

Button (.ct-button) padding
Button border
Button border-radius
Container (.cookie-though) border-radius

Please 🐱

No touch events on mobile

No buttons seam to work on mobile. Both on Android Chrome or iPad Safari.

I've added remote debugging and I got this error when I click a button (or the arrow):

fastclick.js:9 [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See https://www.chromestatus.com/features/5093566007214080
FastClick.onTouchStart @ fastclick.js:9
(anonymous) @ fastclick.js:9

The click event on the button is never triggered.

I'm using the latest version 1.1.3 from https://unpkg.com/[email protected]

All is working well on desktop.

Any thoughts?

Tnx!

Latest build is broken

Uncaught TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.
    at fb (lib.js?:formatted:1141)
    at Object.eval [as __] (lib.js?:formatted:1176)
    at ra (lib.js?:formatted:627)
    at Array.forEach (<anonymous>)
    at eval (lib.js?:formatted:552)
    at Array.forEach (<anonymous>)
    at Gb (lib.js?:formatted:548)

    var fb = function() {
        var e = document.querySelector(".cookie-though")
          , $ = e.shadowRoot.querySelector(".ct-banner-explanation")
          , t = +window.getComputedStyle($).fontSize.slice(0, -2)
          , s = window.innerWidth < 768;

CCPA Compatibility ?

Hello,
Thanks for the module, it looks great, You do not mention though CCPA Compliance, only GDPR's compliance is that something that is taken into account ? Is it compatible with CCPA?

inthepocket / cookie-though Goto Github PK

cookie-though's People

Contributors

Stargazers

Watchers

Forkers

cookie-though's Issues

Discourage dark patterns

Incorrect aria-expanded attribute

Tag a cookie as essential

Add extra CSS variables

No touch events on mobile

Latest build is broken

CCPA Compatibility ?

Add a working demo to the home page

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent