intermesh / groupoffice Goto Github PK

Installed testing licenses but can't activate neither any prof. module nor billing and documents. Error ->

ErrorException in /var/www/html/go63/go/base/db/ActiveRecord.php at line 3122: Undefined index: type

Not sure what's going on here but we get hit with this error while trying to install

ErrorException in /usr/share/groupoffice/go/core/validate/ValidationTrait.php at line 83: count(): Parameter must be an array or an object that implements Countable ErrorException: count(): Parameter must be an array or an object that implements Countable in /usr/share/groupoffice/go/core/validate/ValidationTrait.php:83

Stack trace: #0 [internal function]: go\core\ErrorHandler::errorHandler(2, 'count(): Parame...', '/usr/share/grou...', 83, Array) #1 /usr/share/groupoffice/go/core/validate/ValidationTrait.php(83): count(NULL) #2 /usr/share/groupoffice/go/core/validate/ValidationTrait.php(20): go\core\orm\Property->hasValidationErrors() #3 /usr/share/groupoffice/go/core/orm/Property.php(512): go\core\orm\Property->validate() #4 /usr/share/groupoffice/go/core/acl/model/Acl.php(90): go\core\orm\Property->internalSave() #5 /usr/share/groupoffice/go/core/acl/model/AclEntity.php(55): go\core\acl\model\Acl->internalSave() #6 /usr/share/groupoffice/go/core/acl/model/AclEntity.php(44): go\core\acl\model\AclEntity->createAcl() #7 /usr/share/groupoffice/go/core/orm/Entity.php(136): go\core\acl\model\AclEntity->internalSave() #8 /usr/share/groupoffice/go/core/Installer.php(53): go\core\orm\Entity->save() #9 /usr/share/groupoffice/install/install.php(31): go\core\Installer->install(Array, Array) #10 {main} Debug dump: array(0) { }

In go/base/util/StringHelper.php like 1363, you are using the each() function which is deprecated.

Consider changing code to:

            foreach (array_keys($array_allow) as $key) {
                    $array_allow_tmp[$new_key] = $array_allow[$key];
                    $new_key ++;
            }

Can't choose a different language. I selected German during installation and wanted to change to English in settings - nothing happens.

Sieve is enabled in em_accounts and config.php but can't be used.

line 481.

Can't use count() anymore on null variables without warning

Possible solution:

    public function countRecipients(){
            return count($this->getTo() ?? []) + count($this->getCc() ?? []) + count($this->getBcc() ?? []);
    }

Fatal error: Cannot use go\core\data\Object as Object because 'Object' is a special class name in /usr/share/groupoffice/go/core/data/Store.php on line 7

Add also to folder options menu

It claims the DB is not empty, even though it is empty. Fails on this line:

line 40:

            if (count($database->getTables())) {
                    throw new Exception("Database is not empty");
            }

Audio and image formats

We need to discuss how to determine the full hostname of Group-Office when using cron jobs for example.

For download use zipped format(like GitHub does)

'Object' is reserved in PHP 7.2

Fatal error: Cannot use 'Object' as class name as it is reserved in /usr/share/groupoffice/go/base/Object.php on line 36
[2018-03-13T08:51:20-04:00] ErrorException in /usr/share/groupoffice/go/base/Object.php at line 36: Cannot use 'Object' as class name as it is reserved ErrorException: Cannot use 'Object' as class name as it is reserved in /usr/share/groupoffice/go/base/Object.php:36 Stack trace: #0 [internal function]: go\core\ErrorHandler->shutdown() #1 {main} Debug dump: array(0) { }

If a class is added to a namespace (eg go\modules\vendor\module\Module.php (extended from go\core\module\Base)) and you will refresh your modules Grid then this module will never be found till you remove the file ns-classes-go-modules from the cache2 folder in your filepath.

I think there should be a way to avoid this (eg if in debug mode then don't look after cache, only save new ones, and clear cache with a cli-function) otherwise it will be hard to install new modules in an existing installation.

line 101
This one was a bit tough to replace, without fully understanding the code, but I came up with this. Not sure if it does the same action as the original intended. Please double/triple check

    public function getAddress(){
            $each['value']=reset($this->_addresses);
            $each['key']=key($this->_addresses);
            return $each ? array('email'=>$each['key'], 'personal'=>empty($each['value']) ? $each['key'] : $each['value']) : false;
    }

new modules aren't visible until db check

module "settings" after install without any function

After installing "calendar export" -> Blue Window -> after reinstall DB -> Exception in /var/www/html/go63/go/base/db/ActiveRecord.php at line 1696: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'go63.fav_addressbook' doesn't exist -> after DBCheck -> OK

"demo data" recalls installation question loop after every login

"manual site" doesn't install -> ErrorException in /var/www/html/go63/go/base/db/ActiveRecord.php at line 3122: Undefined index: type

"smime" doesn't install -> ErrorException in /var/www/html/go63/go/base/db/ActiveRecord.php at line 3122: Undefined index: type

"core/test" -> don't know what this is about

Also, in go/core/App.php at line 154 you use '??' which is not valid. Did you want to use ternary operator ?

"dataPath" => $config['file_storage_path'] ?? '/home/groupoffice',

Trying to call file module: ErrorException in /var/www/html/go63/go/base/db/ActiveRecord.php at line 3122: Undefined index: type

Trying to create a folder in file module:
Exception in /var/www/html/go63/go/base/db/ActiveRecord.php at line 938: Could not find ACL for GO\Files\Model\Folder with pk:

Trying to upload a file: nothing happens. After reload: ErrorException in /var/www/html/go63/go/base/db/ActiveRecord.php at line 3122: Undefined index: type

In file:

modules/addressbook/AddressbookModule.php

it appears the 'Best regards' template is uploaded at install time and can't be overwritten. It's also not visible in the Templates list:

As a suggestion:

• move templates to E-mail module, maybe merge with Signatures
• default template should be blank

This is where the template gets added but is not visible after..

            $message = new \GO\Base\Mail\Message();
            $message->setHtmlAlternateBody('{salutation},<br />

install/install.php line 27