Git Product home page Git Product logo

Comments (4)

maksimsab avatar maksimsab commented on June 12, 2024

@victor-eds please, attach the code.

from llvm.

victor-eds avatar victor-eds commented on June 12, 2024

@victor-eds please, attach the code.

Added inline

from llvm.

AlexeySachkov avatar AlexeySachkov commented on June 12, 2024

Some massaging of our enable_ifs is required here:

#ifdef __SYCL_DEVICE_ONLY__
template <
auto &S,
typename T = typename std::remove_reference_t<decltype(S)>::value_type,
std::enable_if_t<std::is_fundamental_v<T>> * = nullptr>
__SYCL_ALWAYS_INLINE T getSpecializationConstantOnDevice() {
const char *SymbolicID = __builtin_sycl_unique_stable_id(S);
return __sycl_getScalar2020SpecConstantValue<T>(
SymbolicID, &S, MSpecializationConstantsBuffer);
}
template <
auto &S,
typename T = typename std::remove_reference_t<decltype(S)>::value_type,
std::enable_if_t<std::is_compound_v<T>> * = nullptr>
__SYCL_ALWAYS_INLINE T getSpecializationConstantOnDevice() {
const char *SymbolicID = __builtin_sycl_unique_stable_id(S);
return __sycl_getComposite2020SpecConstantValue<T>(
SymbolicID, &S, MSpecializationConstantsBuffer);
}
#endif // __SYCL_DEVICE_ONLY__

We have a simple switch between compound and fundamental types, but we should probably use less C++-y terms like composite and scalar to treat more data types as scalar ones, even though they are compound per C++

from llvm.

victor-eds avatar victor-eds commented on June 12, 2024

Some massaging of our enable_ifs is required here:

#ifdef __SYCL_DEVICE_ONLY__
template <
auto &S,
typename T = typename std::remove_reference_t<decltype(S)>::value_type,
std::enable_if_t<std::is_fundamental_v<T>> * = nullptr>
__SYCL_ALWAYS_INLINE T getSpecializationConstantOnDevice() {
const char *SymbolicID = __builtin_sycl_unique_stable_id(S);
return __sycl_getScalar2020SpecConstantValue<T>(
SymbolicID, &S, MSpecializationConstantsBuffer);
}
template <
auto &S,
typename T = typename std::remove_reference_t<decltype(S)>::value_type,
std::enable_if_t<std::is_compound_v<T>> * = nullptr>
__SYCL_ALWAYS_INLINE T getSpecializationConstantOnDevice() {
const char *SymbolicID = __builtin_sycl_unique_stable_id(S);
return __sycl_getComposite2020SpecConstantValue<T>(
SymbolicID, &S, MSpecializationConstantsBuffer);
}
#endif // __SYCL_DEVICE_ONLY__

We have a simple switch between compound and fundamental types, but we should probably use less C++-y terms like composite and scalar to treat more data types as scalar ones, even though they are compound per C++

According to cppreference, enums are scalar types. Maybe using std::is_scalar would fix this?

from llvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.