Comments (4)
steffenlarsen
commented on June 3, 2024
2
I think this is a reasonable idea, but maybe we should just allow both? The reason we use acc is because it is one of the 4 device types in SYCL: cpu, gpu, accelerator and custom (ignoring host, automatic and all). Since ONEAPI_DEVICE_SELECTOR isn't SYCL-specific, we do not have full control over it, so picking accelerator devices when fpga is specified is something we will have to live with, but SYCL_DEVICE_ALLOWLIST is, as the name suggests, SYCL specific, so I would prefer we at least let users use SYCL terminology if they intend to use it.
from llvm.
uditagarwal97
commented on June 3, 2024
@aelovikov-intel @gmlueck thoughts?
from llvm.
aelovikov-intel
commented on June 3, 2024
+ @steffenlarsen @sergey-semenov
from llvm.
gmlueck
commented on June 3, 2024
OK with me.
from llvm.
Related Issues (20)
- Add environment variable to redirect SYCL_PI_TRACE to file
- Add WarpReduce to GENX
- [CUDA][HIP] user_defined_reductions HOT 1
- [SYCL] Non-templated aligned_alloc_xxx functions return non-null when the alignment argument is not a power of 2 on GPU
- [SYCL] throw-exception-for-out-of-registers-on-kernel-launch.cpp failing in WW06'24 pulldown HOT 3
- [SYCL] Several tests failed with OpenCL FPGA in precommit HOT 2
- [SYCL-FUSION] [DebugInfo] Enable support of non-instrinsic debug-info HOT 2
- `sycl::kernel_handler::get_specialization_constant` calls `__sycl_getComposite2020SpecConstantValue` on enumerated `value_type` HOT 4
- sycl_ext_intel_grf_size large grf not working for sycl_explicit_simd kernel HOT 3
- [SYCL][CUDA][BUILD] cuPTI error while building the compiler with CUDA backend HOT 3
- SYCL stream print nothing when kernel is in endless loop HOT 3
- Device code not split in modules when using aspect::atomic64
- SYCL :: Graph/RecordReplay/host_task_multiple_roots.cpp HOT 2
- Error in configure.py on windows 11 HOT 1
- [SYCL][Matrix] Replace size_t with uint32_t to specify joint matrix rows and columns HOT 2
- Test "ESIMD/unified_memory_api/scatter_lacc_dg2_pvc.cpp" failing on unrelated changes HOT 2
- Assert tests fail on Windows Gen12 HOT 1
- Plugin/sycl-ls-unified-runtime.cpp fails on Windows Gen12 HOT 1
- SYCL 2020 discrepancy with Spec on unsampled_image HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from llvm.