intel-media-sdk / product-configs Goto Github PK

Hi,

See this CI build failure: intel/media-driver#731

Please, be aware that this path in media-driver https://github.com/intel/media-driver/blob/master/media_driver/linux/common/os/i915/include/uapi is managed by strict rules described in https://github.com/intel/media-driver/blob/master/media_driver/linux/common/os/i915/include/uapi/README. No changes to the code will be made to satisfy artificial CI requirements such as licence checks, copyrights check, etc. The code is copied from the Linux kernel upstream as-is strictly without modifications. This is critical.

Could you, please, adjust CI verification in media driver to bypass such checks and focus entirely on code buildability.

@XinfengZhang: FYI

Regards,
Dmitry.

Branch: https://github.com/Intel-Media-SDK/MediaSDK/commits/intel-mediasdk-18.4
Commit: Intel-Media-SDK/MediaSDK@7d35bc5
See: http://bb.msdk.intel.com/private/#/builders/1/builds/1800

Android build fails. Please, fix.

PR: Intel-Media-SDK/MediaSDK#1164
Build fails: http://mediasdk.intel.com/buildbot/#builders/17/builds/583

Looks to be some triggerring/checkout issue.

This CI now covers few components besides msdk. For example: intel/media-driver#765. Please, rename msdk build and test targets since it is not obvious what is actually built and tested: build-clang-8.0, build-gcc-9.2.0, etc.

I would also recommend to rename build-driver to build-media-driver since neo is also a driver and this might give confusions.

In our recent msdk we've stepped into not complete switch from clang-10 to clang-11. As result for some time we had clang configuration actually execution gcc. We need to fail instead.

This can be implemented on the basis of this PR: #29

If used compiler != awaited (from builder config in config.py) -> fail the build.

Update conf_how_to.py with:

• Verbose
• Strips

Looking to http://mediasdk.intel.com/buildbot/#builders/61/builds/2403:

[2020-09-16 07:49:26,036] media-driver: cmake INFO: cmd: cmake3 -DMEDIA_VERSION="19.4.0" -DCMAKE_INSTALL_PREFIX=/opt/intel/msdk_driver -DCMAKE_INSTALL_LIBDIR=/opt/intel/msdk_driver/lib64 -DINSTALL_DRIVER_SYSCONF=OFF -DLIBVA_DRIVERS_PATH=/opt/intel/msdk_driver/lib64 -DBUILD_TYPE=release -DENABLE_KERNELS=OFF /docker/worker/driver-kernels-off/build_dir/repos/media-driver

1. MEDIA_VERSION won't take any effect and is eventually wrong. Driver now comes with version in sources. If you want adjust it, you should use MEDIA_VERSION_EXTRA. See here:

https://github.com/intel/media-driver/blob/b285f47f1fb127cc3ca4f677631b6a71321a2db4/CMakeLists.txt#L23

2. Specifying LIBVA_DRIVERS_PATH is weird. This should be fetched automatically if you correctly configured and installed libva. Here is where it is taken into account in the driver code:
   media_driver/cmake/linux/media_include_paths_linux.cmake:33: pkg_get_variable(LIBVA_DRIVERS_PATH libva driverdir)