instruct-br / nameko-reloader Goto Github PK

Ok, here are some items to complete in order to publish the package.

• Remove the lockfile from version control
• Translate code comments
• Translate and review the README
• Include a workflow to build and publish the package

Remove the lockfile from version control

Since this is a library, add the .lock file to .gitinore.

From Poetry docs:

For libraries it is not necessary to commit the lock file.

https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control

Here is another source about when you should keep lockfiles in (or out) of version control:
https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Translate code comments

Translate the docstrings and comments at ~/nameko_reloader/nameko_reloader.py to english.

Translate and review the README

The README in this repository will be available as the "Project description" at PyPI website. Translate it to english and add a minimal documentation:

• A beginning section with a summary describing the package purpose
• A usage section explaining how to use it in your project

See nameko-vault:

• https://github.com/instruct-br/nameko-vault
• https://pypi.org/project/nameko-vault/

Include a workflow to build and publish the package

Copy the workflow from here:
https://github.com/instruct-br/nameko-vault/blob/master/.github/workflows/ci.yml

Replace master with main:

Currently, the reloader only watches changes in the service file.

This issue aims to improve the "watcher" and make it monitor changes in other files used by service too.

Hello! Thanks for the great tool!

I've tried to replace the use of nameko_reloader, instead of nameko cli, to reload my scripts.

However, when I have a config.yml like this, with environment variables, will not work:

# config.yml
AMQP_URI: pyamqp://${RABBITMQ_USER:guest}:${RABBITMQ_PASSWORD:password}@${RABBITMQ_HOST:localhost}

An error like this would be throwed:

[...]
File "/usr/lib/python3.8/urllib/parse.py", line 174, in port
    raise ValueError(message) from None
ValueError: Port could not be cast to integer value as 'localhost}:${RABBIT_PORT:5672}'

The nameko cli uses regex to substitute environment variables. Is there a way this can be supported?

Thanks!

Quando chamamos um evento pelo nameko, as infomações que deveriam ser printadas na tela com "logging.info" ou "print" não estão aparecendo.
Nameko-reloader:

Nameko:

Nameko-reloader currently only watches files passed as argument on startup.

There are cases when the service it's a folder, with a __init__ file with multiple imports. In these cases, the script needs to detect these files and monitoring changes in them too.