Git Product home page Git Product logo

community's People

Contributors

allcontributors[bot] avatar pinglin avatar shihchun-h avatar xiaofei-du avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

community's Issues

Landing page copy issue

The tagline on hero section should be either:

  • Visual Data Preparation Made for All
  • Where Visual Data Preparation is Made for All

The copy under the title 'Integration Vision AI into existing data stack in minutes' should be separated into two sentences not one.

The title 'Fetch, Deploy and Share with the community' needs a comma before and.

image
image

Re-run the integration tests multiple times lead to failure

If we run the make tests multiple times, there is a high possibility the tests in model-backend-rest.js won't pass.


     โ–ˆ Model Backend API: Load model online

       โœ“ POST /models (multipart) cls response Status
       โœ“ POST /models (multipart) cvtask cls response Name
       โœ“ POST /models (multipart) cvtask cls response FullName
       โœ“ POST /models (multipart) cvtask cls response CVTask
       โœ“ POST /models (multipart) cvtask cls response Versions
       โœ“ PATCH /models (multipart) cls response Status
       โœ“ PATCH /models (multipart) cvtask cls response Name
       โœ“ PATCH /models (multipart) cvtask cls response FullName
       โœ— PATCH /models (multipart) cvtask cls response CVTask
        โ†ณ  0% โ€” โœ“ 0 / โœ— 1
       โœ— PATCH /models (multipart) cvtask cls response Versions
        โ†ณ  0% โ€” โœ“ 0 / โœ— 1
       โœ— PATCH /models (multipart) cvtask cls response Version 1 Status
        โ†ณ  0% โ€” โœ“ 0 / โœ— 1

Update description for model version

Now update model version method only support update status ONLINE/OFFLINE. But model version also has description fields to explain what is changed in this version. User wants to update the version description aslo.

Set up release synchronisation CI/CD

We will release a holistic version for all protocol buffer files for all backends.

This is a flavour decision for our API practice. We prefer using a fine-grained version control package instill.pipeline over an imposed-upstream control package instill.pipeline.v1.

When protobufs is released, a GitHub Action workflow will trigger auto-gen for all gRPC client-server codes for all language repos (e.g., protogen-go) and also update all related gRPC/OpenAPI documents

Quick start sample code bug

Deploy the model

If I run the following script in quick start

# Deploy the model
go run deploy-model/main.go --model-path yolov4-onyx-cpu.zip --model-name yolov4

I get a model with model name yolov4 with 1 version.

2022/02/21 00:16:13 model has been created, the response is: id:1 name:"yolov4" full_Name:"local-user/yolov4" cv_task:DETECTION versions:{version:1 model_id:1 description:"YoloV4 for object detection" created_at:{seconds:1645402547 nanos:80792000} updated_at:{seconds:1645402547 nanos:80807000}}

The response missed the status of version 1 of the model.

If I run the above script the second time, I get a model with model name yolov4 with 2 versions.

bash 2022/02/21 00:20:07 model has been created, the response is: id:1 name:"yolov4" full_Name:"local-user/yolov4" cv_task:DETECTION versions:{version:1 model_id:1 description:"YoloV4 for object detection" created_at:{seconds:1645402547 nanos:80792000} updated_at:{seconds:1645402625 nanos:977017000} status:ONLINE} versions:{version:2 model_id:1 description:"YoloV4 for object detection" created_at:{seconds:1645402779 nanos:961661000} updated_at:{seconds:1645402779 nanos:961692000}}

The response only includes the status of version 1, but no status of version 2.

Test the model

# Test the model
go run test-model/main.go --model-name yolov4 --test-image dog.jpg --model-version 2

Get response

2022/02/21 00:24:15 error when triggering predict: rpc error: code = Code(400) desc = {"status":400,"title":"PredictModel","detail":"Model is offline"}

Note: shouldn't we use status code 422 instead of 400 for the above scenario?

But when GET /models/yolov4

{
    "id": 1,
    "name": "yolov4",
    "full_Name": "local-user/yolov4",
    "cv_task": "DETECTION",
    "versions": [
        {
            "version": 1,
            "model_id": 1,
            "description": "YoloV4 for object detection",
            "created_at": "2022-02-21T00:15:47.080792Z",
            "updated_at": "2022-02-21T00:20:09.486272Z",
            "status": "ONLINE"
        },
        {
            "version": 2,
            "model_id": 1,
            "description": "YoloV4 for object detection",
            "created_at": "2022-02-21T00:19:39.961661Z",
            "updated_at": "2022-02-21T00:20:09.486272Z",
            "status": "ONLINE"
        }
    ]
}

The response shows both model versions are online.

`make test` relies on a giant online yolov4 model

When we do

make all
make test

The tests won't pass because the tests rely on an existing online yolov4 model.

We should use a tiny dummy model for testing and fix this issue to make the tests self-contained.

feat: add instill cloud section

Why

  • We don't have instill cloud section on the current landing page.

How

  • Implement new version of landing page design ASAP

Improve the quick start example

When running the quick start example, sometimes it produces errors, for example, Triton server not-ready error (503). We need to improve the example or provide troubleshooting guidelines.

Add validation of recipe

Currently, we only validate model in the recipe. We also need to validate source and destination.

Related issue: #202

Add critical dependency between model and pipeline

Why

An online model (or model version) should not be allowed to be set offline nor to be deleted when it is being used by any activated pipeline.

We need to introduce the above critical dependency to avoid breaking a working pipeline.

Add guideline on how to create a pipeline with user's model

After creating an object detection pipeline by following the quick start tutorial, a user would want to deploy its own model to create a pipeline.

Given a model, we need to provide guidelines on

  • how to verify whether the model is supported or not
  • how to prepare the model to be deployed
  • how to deploy the model and create a pipeline with the model

OpenAPI documentation is out of date in docker-compose

Current redoc deploys the OpenAPI docs from the main branch of the protobufs.
It should deploy the corresponding OpenAPI docs that are compatible with the pipeline-backend and model-backend in the docker-compose.yml.

Models composing an ensemble model won't be unloaded when the ensemble model is unloaded in Triton

The behaviour of unload is different from load for an ensemble model.

load will load all the ensemble model's dependent models into Triton:
https://github.com/instill-ai/model-backend/blob/66b034d0f9ef9af61c2823ae01df111db6c5abaa/pkg/services/model.go#L368

, while unload will unload only the ensemble itself and leave the dependent in the Triton:
https://github.com/instill-ai/model-backend/blob/66b034d0f9ef9af61c2823ae01df111db6c5abaa/pkg/services/model.go#L388

This causes OOM after a few patching on an ensemble model if its dependents are not unloaded together or purged regularly.

Add supported Computer Vision tasks

The current supported Computer Vision (CV) tasks include image classification and object detection.

We need to provide guidelines on

  • how to verify whether an image classification or detection model is supported or not
  • what to do if a model is not supported

refactor: refactor IconBase

Why

Right now, we have IconBase component defined like below, we need to remove default my-auto and make it more flexible

import { FC } from "react";
import * as classNames from "classnames";

interface Props {
  viewBox: string;
  styleName: string;
}

export const IconBase: FC<Props> = ({ children, viewBox, styleName }) => {
  return (
    <svg
      xmlns="http://www.w3.org/2000/svg"
      viewBox={viewBox}
      className={classNames.default("fill-current my-auto", styleName)}
    >
      {children}
    </svg>
  );
};

[release] v0.2.0-alpha

Issues to be resolved for v0.2.0-alpha release will be added here.

Backends

pipeline-backend

  • Support creating a SYNC pipeline with http as source, MySQL as destination.

vdp

  • Use the latest docker images for all backends
  • #46
  • [ ] Add Roadmap

GSAP license issue

Why

GSAP is a open-source package we use for product website's animation, it is charged once we have paid users, so we need to consider adapt other animation package in the future

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.