inrule / samples Goto Github PK

Discussion on whether or not what's currently in the /WindowsContainers folder should be moved into an independent repository.

Pros:

• keeps sample content separate from container assets
• reduces noise in Samples repos
• Simplifies CI/CD processes for container images
• Easier to make, test, and surface changes when what's being tested isn't a subfolder of a much larger structure

Cons:

• Makes Yet Another Repository that needs to be maintained
• Would necessarily be a sparse repos since the InRule assets must be provided separately
• If/When additional containers examples are added (e.g., Mortgage Calculator container image built from base sample images), could add friction

Officially updated and maintained containers would allow customers to get up to speed and stay updated far easier

Appears to be a comment, but isn't a comment line.

It causes this output when the container starts:

controlled : The term 'controlled' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling of the name, or
if a path was included, verify that the path is correct and try again.
At C:\temp\Set-RuntimeConfig.ps1:71 char:5

I am proposing a data driven MsTest wrapper for testuite files.
It allows to integrate testsuite in a MsTest report. It creates the preconditions to wire the tests to an Azure Devops (or other hosted service) CICD pipeline.

Many of the samples seem to have had the contents of the /packages directory committed to source control. For example, https://github.com/InRule/Samples/tree/v5.0.28/Developer%20Samples/RuleServices45/packages is one of them.

None of the samples should have the contents of their package directories in source control. This may have some overlap with issue #4

Consider using default irSDK install directory as a file-based package source in the NuGet.config for projects.

Contribution guidance is very basic currently - they could use a separate section in the repos' README. Specifics are up to @InRule/engineering, but this might also be a good opportunity as well to set contributor's expectations re: response times and feedback on PR's. For reference, here is the VS Code contrib guidelines:

Contributing

If you are interested in fixing issues and contributing directly to the code base,
please see the document How to Contribute, which covers the following:

• How to build and run from source
• The development workflow, including debugging and running tests
• Coding Guidelines
• Submitting pull requests

Please see also our Code of Conduct.

Hi,

I've attempted to make use of volume mounts to inject the InRuleLicense.xml file into a Windows Container image at runtime (which would mean you don't need to make a specific image for any given machine you want to run it on).

docker run -d --restart unless-stopped --name ircatalog -e CatalogUser=xxx -e CatalogPassword=yyy -e CatalogDbHost=zzz -e CatalogDbName=ircatalog-db -p 8100:80 -v "C:\Users\Sam\Documents\InRule\License\:C:\ProgramData\InRule\SharedLicenses\:ro" server/inrule-catalog:5.0.26

Unfortunately, I haven't had much luck at actually getting InRule to pick up the license using this method. I've tried mounting a folder containing the license file in the same location as one that's baked into an image, but it always says it's running in grace period mode when using the volume mounted license folder.

The only difference I can see, inside the container, is that the volume mounted folder is a symlink directory, instead of a "real" folder. I'm able to read the license file inside the symlinked folder though.

11/21/2017 02:39 PM <SYMLINKD> TestVolume [\\?\ContainerMappedDirectories\71953C40-5FB5-44FC-ADDF-43763C99372E]

Any ideas why this might be the case?