Multisig Coordination Server

License: Apache License 2.0

Dockerfile 3.03% JavaScript 1.63% Nix 14.92% Shell 0.83% TypeScript 77.44% HTML 2.14%

adrestia-multisig-coordination's People

Contributors

Stargazers

Watchers

Forkers

alanverbner mitchelltesla rmourey26

adrestia-multisig-coordination's Issues

Base Dockerfile on Ubuntu 20

In line with the reasons provided in the Rosetta spec, let's base the Docker image on Ubuntu 20 to minimise the variables across Adrestia products.

https://github.com/input-output-hk/cardano-rosetta/blob/master/Dockerfile#L79

nix-build failing - attribute 'yarn-static' missing

$ nix-build --show-trace
error: while evaluating 'mkAttrOverridable' at /nix/store/kf3adfr28xj77rmqbzy98qil86380zgv-nixpkgs-src/lib/customisation.nix:133:33, called from undefined position:
while evaluating 'makeOverridable' at /nix/store/kf3adfr28xj77rmqbzy98qil86380zgv-nixpkgs-src/lib/customisation.nix:67:24, called from /nix/store/kf3adfr28xj77rmqbzy98qil86380zgv-nixpkgs-src/lib/customisation.nix:133:36:
while evaluating anonymous function at /nix/store/kf3adfr28xj77rmqbzy98qil86380zgv-nixpkgs-src/lib/customisation.nix:133:53, called from /nix/store/kf3adfr28xj77rmqbzy98qil86380zgv-nixpkgs-src/lib/customisation.nix:69:16:
while evaluating the attribute 'offlinecache' at {...}/adrestia-multisig-coordination/nix/packages.nix:9:40:
attribute 'yarn-static' missing, at {...}/adrestia-multisig-coordination/nix/packages.nix:9:14

TypeScript errors

Argument type (instance: FastifyInstance<http.Server, http.IncomingMessage, http.ServerResponse>, options: PluginOptions, callback: (err?: (import("fastify").FastifyError | undefined)) => void) => void is not assignable to parameter type Plugin<http.Server, http.IncomingMessage, http.ServerResponse, PluginOptions, Function>

Pin Node.js Docker image to LTS

adrestia-multisig-coordination/docker-compose.yml

Line 27 in 799373d

image: node

image: node:lts

Dead code

These are unused. It's either dead code or untested code 😉

adrestia-multisig-coordination/src/server/utils/formatters.ts

Lines 5 to 7 in f4ff294

 export const hexFormatter = (buffer: Buffer): string => buffer.toString('hex'); 

 export const hashStringToBuffer = (hash: string): Buffer => Buffer.from(hash, 'hex');

Missing await for an async function call

adrestia-multisig-coordination/src/server/services/message-service.ts

Line 26 in 799373d

this.notificationService.sendMessageToChannel(channelId, message);

Mounting whole context into Docker container

This tells me the image is not portable, and should be refactored to include minimally required files at build time.

adrestia-multisig-coordination/docker-compose.yml

Lines 48 to 49 in 799373d

 volumes: 

 - ./:/home/node/app

Missing JSDoc detail

yarn lint


/home/rhys/code/iohk/adrestia-multisig-coordination/test/e2e/jest-setup/docker.ts
  5:8  warning  'path' is defined but never used                         @typescript-eslint/no-unused-vars
  8:7  warning  'CONTAINER_TEMP_DIR' is assigned a value but never used  @typescript-eslint/no-unused-vars

/home/rhys/code/iohk/adrestia-multisig-coordination/src/server/controllers/controllers.ts
  4:1  warning  Missing JSDoc @returns declaration    jsdoc/require-returns
  7:0  warning  Missing JSDoc @param "services" type  jsdoc/require-param-type

/home/rhys/code/iohk/adrestia-multisig-coordination/src/server/db/connection.ts
  5:1  warning  Missing JSDoc @returns declaration            jsdoc/require-returns
  8:0  warning  Missing JSDoc @param "connectionString" type  jsdoc/require-param-type

✖ 6 problems (0 errors, 6 warnings)

Done in 2.08s.

Probably best to treat JSDoc lint issues as errors so this is caught it CI

Invalid JSDoc

adrestia-multisig-coordination/src/server/server.ts

Lines 16 to 25 in 49606f7

  * This function builds a Fastify instance connecting the services with the 

  * corresponding fastify route handlers. 

  * 

  * @param services to be used to handle the requests 

  * @param logger true if logger should be enabled, false otherwise 

  */ 

 const buildServer = ( 

 servicesFactory: (httpServer: Server) => Services, 

 logLevel: string 

 ): FastifyInstance<Server, IncomingMessage, ServerResponse> => {

	export const hexFormatter = (buffer: Buffer): string => buffer.toString('hex');

	export const hashStringToBuffer = (hash: string): Buffer => Buffer.from(hash, 'hex');

	* This function builds a Fastify instance connecting the services with the
	* corresponding fastify route handlers.
	*
	* @param services to be used to handle the requests
	* @param logger true if logger should be enabled, false otherwise
	*/
	const buildServer = (
	servicesFactory: (httpServer: Server) => Services,
	logLevel: string
	): FastifyInstance<Server, IncomingMessage, ServerResponse> => {

input-output-hk / adrestia-multisig-coordination Goto Github PK

adrestia-multisig-coordination's People

Contributors

Stargazers

Watchers

Forkers

adrestia-multisig-coordination's Issues

Recommend Projects

Recommend Topics

Recommend Org