Git Product home page Git Product logo

foreman_expire_hosts's People

Contributors

ahmet2mir avatar iakovgan avatar nagarjuna avatar ohadlevy avatar timogoebel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

foreman_expire_hosts's Issues

Licence should be GPLv3+

Foreman itself is GPLv3+ and plugins are usually regarded as derivative works (IMHO), which would put it under the same licence. I don't believe MIT is possible here.

Could you please change the LICENSE file back to GPLv3+? It was changed to MIT in 9a40218.

release as a gem

Hi,

Can you please release as a gem? this would allow us to use it bundler or to package it at theforeman.org..

thanks

dd/mm/yyyy format is confusing

Using dd/mm/yyyy format for the expired_on parameter is confusing because, native english user would read it like mm/dd/yyyy.

Changing to ISO format yyyy-mm-dd would avoid such issues.

plugin settings are confusing

Hi,

just wondering, out of the below example (copied from the readme) - why do we need settings like

  • :view: :expired_on_input_field
    
  • :host_show: :view: :expired_on_field

I would assume other positioning objects (like after) is even not really going to be used by users?

:host_expired_on:
  :host_form:
    :view: :expired_on_input_field
    :after: model_name
    :is_mandatory: true  # This can be modified to true/false. If this is true then host will not allow to create with out expired_on value
  :host_show:
    :view: :expired_on_field
  :delete_hosts:
    :notify1_days_before_expiry: 7 # Send first notification to owner of hosts about his hosts expiring in given days. Default = 7 days before host expiry
    :notify2_days_before_expiry: 1 # Second notification. Default = 1 days before host expiry
    :days_to_delete_after_expiration: 3 # Delete expired hosts after given days of hosts expiry date. Default = 3 days of it expiry
    :notify_emails: ["foreman-admin@your_foreman.com", "foreman-admin2@your_foreman.com"] # All notifications will be delivered to its owner. If any other users/admins need to receive those expiry wanting notifications then those emails can be configured here. This is the Array of email address and can give multiple emails in array. If no users need to receive notifications then this can be empty array []

Also, I think the best thing would be to move these settings into proper settings objects, then they could be edited under settings and not require application restart?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.