infrabel / themes-gnap Goto Github PK

With progress bar and pluggable backend

https://github.com/johnpapa/angularjs-styleguide#controllers

Use the vm syntax, https://raw.githubusercontent.com/johnpapa/angularjs-styleguide/master/assets/above-the-fold-1.png

Call it "vm" in the view as well

https://github.com/johnpapa/angularjs-styleguide#exception-handling

Directives for validation + messages

Currently the sidebar only renders ng-click to a select() method. This is done because the developer can do some interaction when he registers a click on a sidebar menu item.

We should detect if a state is registered (and no click), then we should add a ui-sref to it.

Document how the APIs work, so people from the backend can implement them in parallel

• Translation
• Languages

• Login: Enter should submit

ace.js now has dummy typeahead info, disable it

Setup linting: https://github.com/johnpapa/angularjs-styleguide#js-hint

In addition to NuGet packages, produce Artifactory (Java) things too

Normally the tooltips have a color, but now they are all black. Probably some css is wrong because we append them to body.

Currently when a user visits the site, we determine the default language by checking and window navigator language.

This is better than just hard coding a default, since it checks at the language of the browser, which probably is the same as the language of the user.

However, this is not always the case. But since we don't have access to accept headers in javascript, this information has to come from the server.

Thus we should provide a facility to set the language programmatically, but only on first load.

• Loading icon before everything is initialized

Run HTML minifier and see if the UI looks the same (no dependencies on newline whitespaces)

Try to not depend on layout.js, ace.js and ace-extra.js for the Angular things. Since these files are mostly jQuery orchestration which we should now do in directives etc

In addition to NuGet packages, produce Bower things too

Cleanup example app with best practices

Does it automatically display for http requests? Do we want that?

Could also check out https://github.com/chieffancypants/angular-loading-bar

Currently we are using "localStorage" directly, create a service or have a look at:

• http://ngmodules.org/modules/ngStorage
• https://github.com/grevory/angular-local-storage

Let's try to not reinvent the wheel.

Add an example on how to use the local storage service in your app config

bootbox.js version that we have now allows only textbox as input in a prompt.

We need to have the latest version to be able to add a select or other input.

Thanks.

• Layout of datepicker and daterange picker is broken
• Logic of daterange picker differs from plain

Can you please update the theme to be able to have the new fontawesome icons

Thanks

Images should be compressed during build

What's the unit testing story?

https://github.com/johnpapa/angularjs-styleguide#testing

Provide an example for a confirm box, like used in "Are you sure you want to delete this?"

Use case:

• I don't want to add the full breadcrumb state for every page.
• Let me just manage the breadcrumb of the state I am in, while inheriting from the parents

• yo gnap

Provide skeleton with login, etc

Currently the template paths of the directives go to 'js/....'

When they are installed, they end up in 'vendor/gnap.../js/....', giving a 404

We should fix this

• Put the correct full template in the directive
• Use some mechanism like bootstrap ui which has templates in code

Action part of responsive table looks ugly, need to style it better.

Currently, we serve .json files with translations. These files can contain characters such as À, which should be saved as UTF-8 to work properly in the theme.

For some users, this is actually quite a big step (perhaps one that we can resolve with just having a yo translation generator). Some people will see their characters come out as question marks, and will try to replace them with html entities, requiring them to abandon the translate filter and use the directive, or have ng-bind-html everywhere (possibly unwanted)

Are there other things that can help us?

Most user friendly practice would be to let the user type in special characters without worrying, and then we somehow always interpret those files as UTF-8, or we let the server serve them with UTF-8 charset defined on it (always without BOM anyway)

• Login page is for issue #39
• Getting started page is for issue #27

Go over all examples and check for info that can be removed (classes, ids)
Also have a look at indenting to make them consistent (4 spaces)

The sidebar directive uses a controller that accepts a $scope. During minification this scope is renamed which causes the directive to raise an error.

Currently the dropdown button example is very basic, we should add some real click events to it with a controller and some alerts.

Logic of daterange picker differs from plain