infocatcher / link_properties_plus Goto Github PK

(also see https://bugzilla.mozilla.org/show_bug.cgi?id=1155996)
Now we can use resource://gre/modules/PrivateBrowsingUtils.jsm only for browser windows (and not for content windows).
And for Private Tab support we should use privateTab.isTabPrivate(), see Infocatcher/Private_Tab#208 (fixed version not yet released).

After clicking on a download link, the following error is shown in the browser console:

Timestamp: 07.10.2013 20:09:11
Error: [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: chrome://linkpropsplus/content/linkPropsPlus.js :: linkPropsPlusSvc.realReferer :: line 821"  data: no]
Source File: chrome://linkpropsplus/content/linkPropsPlus.js
Line: 825

This happens with at least Firefox 23 and 24 in a new profile with only LPP 1.5.2 installed.
This bug also has negative effects on other addons like TabMix Plus 0.4.1.2.

Accept-Ranges: bytes + available Content-Length ?
But what about FTP?

We can use color indication to don't increase window height: use green font for Status: 200 OK.

Because HEAD request isn't supported by some server-side backends.

We may add Send GET Request item to our context menu for left column. And (probably) add special context menu to Get properties button.

Reported here: https://forum.mozilla-russia.org/viewtopic.php?pid=742599#p742599
Example: https://dl.google.com/dl/softwareremovaltool/win/software_removal_tool.exe
Response:

accept-ranges: bytes
content-length: 3923576
content-type: application/octet-stream
etag: "16a791"
last-modified: Wed, 30 Aug 2017 14:26:57 GMT
server: downloads
vary: *
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-xss-protection: 1; mode=block
date: Fri, 08 Sep 2017 08:24:46 GMT
alt-svc: quic=":443"; ma=2592000; v="39,38,37,35"
X-Firefox-Spdy: h2
X-NoScript-ReqData: {}

RFC 7230 - Hypertext Transfer Protocol (HTTP/1.1): 3.2. Header Fields

Each header field consists of a case-insensitive field name followed
by a colon (":"), optional leading whitespace, the field value, and
optional trailing whitespace.

We use Application.getExtensions().
See https://bugzilla.mozilla.org/show_bug.cgi?id=1090880

We already have extensions.linkPropertiesPlus.key.openWindow and it's good to have ability to configure other hotkeys like Ctrl+Shift+C from #5.

hello, do you plan a webextension for this good extension?
greetings

chrome://messenger/content/messageWindow.xul

We should use private mode to send requests for links from private window.

We can use nsIPrivateBrowsingChannel to do this:
Forcing a channel into private mode
nsIPrivateBrowsingChannel.idl

Hi.
Could you please sign your Link Properties Plus WE?
Best regards,
Igor.

See Breaking changes in let and const.
Now COL_IMAGE_ADDRESS and COL_IMAGE_NODE aren't visible:
chrome://browser/content/pageinfo/pageInfo.js

const COL_IMAGE_ADDRESS = 0;
const COL_IMAGE_TYPE    = 1;
const COL_IMAGE_SIZE    = 2;
const COL_IMAGE_ALT     = 3;
const COL_IMAGE_COUNT   = 4;
const COL_IMAGE_NODE    = 5;
const COL_IMAGE_BG      = 6;

Some researches:

• We can't use simple <html:div />: Ctrl+C will copy data without formatting, but all looks fine with HTML inside <iframe>. Also <iframe type="chrome" /> doesn't receive focus (so, we can't use simple data: URI with chrome:// styles).
• We should use <br /> to correctly copy data with newlines (also see bug 116083).
• In our custom "copy row" function we can't use .textContent, it doesn't contain newlines, so we can use .innerHTML + replace or select all text and use .getSelection().toString() (and selection.getRangeAt() may return data without newlines).
• We should implement context menu manually.
• We can't use hidden="true" to hide blocks with <iftame> in old Firefox versions (and we have troubles with built-in autosizing with collapsed="true").

Sub tasks:

• Make sections in HTTP headers collapsable #9
• Show request headers modifications from browser or other extensions #13 (related, no easy way to patch plain text headers)

I see some issues and questions duing localization testing.
I can't reproduce some features:
contextOnSelection
linkPropsPlus.copy*
linkPropsPlus.opts.downloadDialog

showInAppMenu is not working properly in Fx28.0, I see it is placed on DevTools menu instead of the App menu.

Due to https://bugzilla.mozilla.org/show_bug.cgi?id=999003, "Number.toLocaleString() without locale returns localized digits specified by the OS"

https://github.com/Infocatcher/Link_Properties_Plus/blob/1.5.2/chrome/content/linkPropsPlus.js#L983-L994

In resource://gre/modules/DownloadUtils.jsm:

this.__defineGetter__("gDecimalSymbol", function() {
  delete this.gDecimalSymbol;
  return this.gDecimalSymbol = Number(5.4).toLocaleString().match(/\D/);
});

(from Firefox 33.0a1 (2014-06-25), also see https://bugzilla.mozilla.org/show_bug.cgi?id=1009795)

Anyway, our implementation is better: will be used 123 456.78, if localized numbers doesn't contain digits.

For better startup performance...

With #10 we will have icon for button.
Also toolbar button needed for Australis menu-button...

Special:

• Implement ability to drag link into button, that placed inside Australis menu-button #16

It's would be good to show all intermediate redirects.
May be as tooltip for "direct link" field?

Something like
http://getfirefox.com/
⇒ http://www.mozilla.org/firefox/?from=getfirefox
⇒ http://www.mozilla.org/en-US/firefox/new/?from=getfirefox

We can use something like https://www.iconfinder.com/icons/36291/link_page_white_icon:

You can watch this issue to receive notifications about changes in localization.
See Subscribe button on right side:

Enhancement for #11.

(Probably happens only sometimes...)
Note: also something went wrong with edit attribute dialog in DOM Inspector.

Also was reproduced here: http://forum.ru-board.com/topic.cgi?forum=5&topic=48192&start=180#15

Enhancement for #8.
Example:

[+] Request
[−] Response
Some
Data
Here

Example:

Services.obs.addObserver(observer, "http-on-modify-request", false);
setTimeout(function() {
    Services.obs.removeObserver(observer, "http-on-modify-request");
}, 5e3);
function observer(subject, topic, data) {
    if(subject instanceof Components.interfaces.nsIHttpChannel) {
        subject.setRequestHeader("Referer", "https://google.com/", false);
        subject.setRequestHeader("User-Agent", "", false);
        subject.setRequestHeader("X-Test", "test", false);
    }
}

New string introduced in #2:

chrome/locale/fr/linkPropsPlus.properties
534561c#diff-2 + 0f96f9c#diff-2

chrome/locale/fr/linkPropsPlus.dtd
706acf7#diff-3