infinitelibrary / infinite-electron Goto Github PK
View Code? Open in Web Editor NEWAn Electron-based cross-platform desktop reader for free ebooks
License: MIT License
An Electron-based cross-platform desktop reader for free ebooks
License: MIT License
Hi everyone! I'm subscribed to the old Infinite Library repo from the first hackathon, so I get all the notifications. Since this project looks super interesting, I thought I'd build it and give it a try. Sadly, I just can't figure out how to get it to build. Here's what I've tried:
git clone https://github.com/InfiniteLibrary/infinite-electron
cd infinite-electron
yarn
and here's what I get:
$ yarn
yarn install v0.20.0
[1/4] Resolving packages...
success Already up-to-date.
$ concurrently "install-app-deps" "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json"
[0] zsh:1: command not found: install-app-deps
[0] install-app-deps exited with code 127
[1] node node_modules/fbjs-scripts/node/check-dev-engines.js package.json exited with code 0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
I tried npm install -g install-app-deps
, and that gives me the executable install-app-deps
, but then I get the same error as above, even after restarting the session.
I think that what we have right now has the potential to get people excited, maybe even some people who can help us implement the finishing pieces. I'd like to publicize this through the Unglue.it mailing list (about 4,000 people), through the Knight Foundation (which sponsored some of our work on GITenberg), DPLA, and the CODEX hackathon network; we can see if hacker news likes it.
What do others think?
The desktop file is lacking a Categories=
entry in the *.desktop
file.
According to the menu spec,
By including one of the Main Categories in an application's desktop entry file, the application will be ensured that it will show up in a section of the application menu dedicated to this category. If multiple Main Categories are included in a single desktop entry file, the entry may appear more than once in the menu.
Hence, please add at least one of the following in the Categories=
key.
Main Category | Description | Notes |
---|---|---|
AudioVideo | Application for presenting, creating, or processing multimedia (audio/video) | |
Audio | An audio application | Desktop entry must include AudioVideo as well |
Video | A video application | Desktop entry must include AudioVideo as well |
Development | An application for development | |
Education | Educational software | |
Game | A game | |
Graphics | Application for viewing, creating, or processing graphics | |
Network | Network application such as a web browser | |
Office | An office type application | |
Science | Scientific software | |
Settings | Settings applications | Entries may appear in a separate menu or as part of a "Control Center" |
System | System application, "System Tools" such as say a log viewer or network monitor | |
Utility | Small utility application, "Accessories" |
In addition, you could specify one or more from the longer list of Additional Categories.
Please test the result with desktop-file-validate
and make sure it passes.
electron-builder offers native support for this since v19.22.1.
Reference: AppImage/appimage.github.io#2
cc: @fchasen @ekmartin @eshellman
Now that we have a basic version of the app working (hooray!), it would be great to polish things up over the next few weeks/months as time allows. I'm happy to continue doing UI work and implementing other features where I can.
Here are some things I can think we may want to tackle in future development:
Any others?
Currently it is hard for users to download and try infinite-electron on Linux. One has to install yarn, and run multiple commands. It would be great if there was an easier way: download one file, and be ready to roll.
Providing an AppImage would have, among others, these advantages:
appimaged
Here is an overview of projects that are already distributing upstream-provided, official AppImages.
electron-builder has support for generating AppImages built in. In fact, it is the default for Linux.
Electron supports a few different methods for running an app without the gray menu bar on MacOS (apparently this works on some Linux distros as well).
In my opinion this goes a long way towards making the app feel "native". Compare this (default navbar):
Of course, the UI elements in the top left start to collide and will need to be adjusted for this approach:
I'm going to explore some design solutions for this problem in the ui-improvements
branch, and if folks like the results I'll merge into master.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.