inery-blockchain / inery-testnet-faucet-tasks Goto Github PK

i have no idea what you guys thinking while seeing task 4 pull request, but could you see this https://github.com/inery-blockchain/inery-testnet-faucet-tasks/tree/task4/agustina and this repo https://github.com/inery-blockchain/inery-testnet-faucet-tasks/blob/task4/lightbulb

they look like same didn't they? of course they are, and could you see my task 4 here https://github.com/inery-blockchain/inery-testnet-faucet-tasks/tree/task4/nyeka, what you guys think about? yeah they clone my task 4 work.

to be honest, i was spent my whole day just to wrote that code, faced a lot of error, and tried to understand what is going on that code, but all these people doing just cloning my work and submitted my task 4 without even changing the function name, and just changed my name on that code.

i was thinking that all day long, is that even fair? i was doing all the work and they just cloning mine and you approved them?

after this issue comming, you might see on the pull request that has same solution like mine.

I have attempted to run the tasks provided in the merged Inery Task 4, however, I have encountered several issues. Upon inspection, it appears that a significant number of the merged tasks contain missing dependencies or other errors that prevent them from running properly. I am unsure of the process by which the Inery team merges tasks, as it appears that the code is not being thoroughly tested before being merged.

It's not fair for people who spent his time to understand how IneryJS API works and create solution for their task 4 , despite the absence of community dev in the Discord server, to help upcoming dev to join the inery ecosystem.

I understand that a professional QA process is in place, however, it seems that there are a significant number of bugs present in the current solutions. The Inery team should exercise caution when merging tasks to ensure that the code is fully functional and free of errors. This is especially important for a new blockchain project, as it is essential to maintain a professional and reliable image to potential users and developers.

#642 by aalifa
I am having difficulty understanding how this task was approved for merging. Upon initial installation, I encountered an error related to an issue with the JSON structure. I am curious as to how this task passed the approval process. Were the npm scripts successfully run during the testing phase? It is imperative that any bugs or issues are identified and addressed prior to approval, to ensure the highest quality of code for the project.

#694 by aruma
Upon conducting a thorough review of the task, it appears that the package.json file is missing the npm scripts for "rpc_token_create," "rpc_token_issue," and "rpc_token_transfer," as described in the associated readme documentation. This would prevent the task from running as intended. It is essential that all necessary scripts and dependencies are included in the package.json file to ensure proper functionality of the task.

#659 by azey
I have a question regarding the task, are we utilizing the eosjs module to execute the script? I attempted to run the task as described in the Readme file, but it appears that the task is not functioning as intended. Upon further investigation, it appears that the eosjs package is not present in the package.json file. Additionally, even if the eosjs package is present in the package.json file, It is uncertain if it is able to execute its script as we are working on inery blockchain not eos blockchain.

#264 by blikribo
where is inerjs module ? how you could run the script while there are no ineryjs module on his solution...

by ikbal.nodex
same issue, package.json is not valid
also if you check the script, it will not run anything and will have many bug and error.

and try to fix the package.json and test it, and we will get a lot of error
where is the pushTransaction.js as described by his readme ?

referencing account variable, but he didnt declare its variable ?

i don't know what happen, it;s been merged and you guys flag it as duplicate before, and i gave you a comment how you guys should check the PR, please check my PR #133