Git Product home page Git Product logo

magento2-inchoo_stripe's People

Contributors

ivanweiler avatar udovicic avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

magento2-inchoo_stripe's Issues

Thos module affects whole Checkout “Design” and “E-Mails”, Why?

I recently installed this extension. Works so far, but I noticed, the extension does affect the look/design of my checkout and also changes the e-mails structure..
I found out that it has probably something to do with the JS files in https://github.com/Inchoo/magento2-Inchoo_Stripe/tree/master/view/frontend/web/js/view/payment

Does someone know how to change / remove this file, so it does not affect my checkout design and order email?

Thanks alot. :)

Module not shown/loaded in checkout

During checkout the module is not loaded, how ever it works fine in adminhtml.
I have tested all 3 branches with the same result.

I don't know if i'm doing something wrong?

Keep up the good work.
BR.
Jesper

Stripe.js compatibility

Logic: Instead of posting cc, cvv, etc, grab them with js, call stripe.js, get token, inject token, post token

Problem: Hook on what, Magento isn't submiting forms on checkout, he's "collecting" payment info with js and sends it with ajax on both payment continue and place order. Sending payment info through ajax 2 times + validate() in pgw 2 times. So we can't use onsubmit or similar.

_ajax( something + payment.form.serialize() )

Integration:
It seems the only way to achieve this is to mess with Magento checkout javascript (rewrite core widgets, block on continue click or similar) which is slightly aggressive. Also, I assume things are different in onepage vs multishipping vs order from admin, not to mention future onestep checkouts.
I also can't find custom "fire" events in js which exists in Mage1. Most likely they didn't need them yet for Mage2 EE :)

It's interesting that similar rewrites are seen in \app\code\Magento\Authorizenet\view\frontend\web\js\direct-post.js ( placeOrder.off('click').on('click', new_logic) )

One more thing, I didn't test, but it's mentioned at one place that "stripe tokens can only be used once". Since multishipping is creating multiple orders in a loop, multiple payment calls are executed, so token approach can't work here ?!?

Conclusion:
Funny thing is, if we implement usual backend cc non-token way, we're compatible with everything at the same time.

Go with backend cc approach, branch stripe.js approach and make it work on onepage as Mage2 practice for start? Suggestions?

Encrypted settings needs testing on php7

@udovicic
I disabled encrypted settings while working on feature/stripejs (only on this branch), for some reason they aren't decrypted when called ?!? or something similar. Win/php7 configuration.

https://github.com/Inchoo/magento2-Inchoo_Stripe/blob/feature/stripejs/etc/adminhtml/system.xml#L30

I didn't had time to check why, since xdebug is also causing me some problems on win/php7. What can I say, lousy day :)

Anyway, it's possible M2 has some problems with this on php7.

JS errors on checkout while using stripe.js branch

Having troubles while using stripe.js branch - after filling out CC data and placing order, checkout process hangs, there is no order confirmation message (if test CC was valid, it goes through to Stripe, and in Magento backend order is made, complete with transaction), though if an invalid CC was picked (that would return card_declined message), process hangs and in console there are javascript errors:

jquery.js:9666 POST http://dev.dev.com/en/rest/en/V1/carts/mine/payment-information 400 (Bad Request)

error-processor.js:20 Uncaught TypeError: messageContainer.addErrorMessage is not a function

Is stripejs branch compatible with Magento 2.1 ?

please insert a valid credit card expiration date

Hi, I managed to install the inchoo stripe module , but when I go on the checkout page and insert the credit card info , when I try to pay I get please insert a valid credit card expiration date error. I have tryed with several credit cards , and allways get the same error.

Error on enabling the module

Hi there,
I am trying to install the module on my local environment. I run the environment with a vagrant using rgranadino/mage2_vagrant. I am able to install it using composer, however when I run bin/magento module:enable Inchoo_Stripe --clear-static-content I get the following error: "Unknown module(s): 'Inchoo_Stripe'"
Any help will be very appreciated!

best way to include init.php in magento2 without composer

hi all,

my question is where should I call

require_once('stripe-php-master/init.php');

the best?

If I do it in the config.php of the module itself it works but on compilation it gives an error.
Couldnt find any info on this.

Important note: NO Composer installed so not possible via composer

Item wise Refund (Partial Refund) Bug

Module is working fine in front end and back end.

When i refund partial it refunds the total amount instead the partial amount.

please check and let me know if you have solution for that issue.

Setup version for module 'Inchoo_Stripe' is not specified"

Hello Stjepan,

See images.

Return this error.

a:4:{i:0;s:57:"Setup version for module 'Inchoo_Stripe' is not specified";i:1;s:1772:"#0 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/lib/internal/Magento/Framework/Module/DbVersionInfo.php(56): Magento\Framework\Module\DbVersionInfo->isModuleVersionEqual('Inchoo_Stripe', '1.0')
#1 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/lib/internal/Magento/Framework/Module/DbVersionInfo.php(79): Magento\Framework\Module\DbVersionInfo->isSchemaUpToDate('Inchoo_Stripe')
#2 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/lib/internal/Magento/Framework/Module/Plugin/DbStatusValidator.php(55): Magento\Framework\Module\DbVersionInfo->getDbVersionErrors()
#3 [internal function]: Magento\Framework\Module\Plugin\DbStatusValidator->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#4 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/var/generation/Magento/Framework/App/FrontController/Interceptor.php(100): call_user_func_array(Array, Array)
#5 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/var/generation/Magento/Framework/App/FrontController/Interceptor.php(124): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, Array)
#6 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/lib/internal/Magento/Framework/App/Http.php(115): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#7 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/lib/internal/Magento/Framework/App/Bootstrap.php(245): Magento\Framework\App\Http->launch()
#8 /home/magento2ubuntu1404/dados/public_html/ambiente02/magento2/index.php(39): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http))
#9 {main}";s:3:"url";s:49:"/public_html/ambiente02/magento2/index.php/admin/";s:11:"script_name";s:42:"/public_html/ambiente02/magento2/index.php";}

captura de tela de 2015-04-11 13 01 32

captura de tela de 2015-04-11 13 03 06

Cheers,

Marcelo Amorim

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.