inbasic / ignotifier Goto Github PK

View Code? Open in Web Editor NEW

389.0 33.0 116.0 20.17 MB

Multiple account Gmail notifier (without storing passwords)

Home Page: https://webextension.org/listing/gmail-notifier.html

License: Other

JavaScript 83.48% CSS 5.37% HTML 11.15%

chrome chrome-extension edge-addon firefox-ad javascript opera-addon

ignotifier's People

Contributors

Stargazers

Watchers

Forkers

catzil fy072 hiccups1980 emailforviny alexfrhee dracx storagebot freaking1 jorisha buddystar-studios enriquefariasrdz billyoc iscgroup miniol dantgit juan1to acidburn0zzz davgit elerocks marypaz irkinosor vovazubko kissdanigh suensummit padaquack24 skhorne cnlhkj snerfu ecostaoli ofer43211 lililya521 lililililil ratulghosh tweezy23 erikvold yograf vinniebii aristide privat1 tonyvu939 greatsunny thethakuri orans2016 jmcelreavey zdenu sbpallekumbura reachingout flybread danielweber7624 labanhspo cemal21 sijera letsjstfk casey-looney shroukkhan scarfa rudra012 arxarian gitter-badger paolme mkiol shubham19995 piyush-411031 veltzen zhangdianchao ildarkhasanshin lhfei enterstudios universal-it-systems be47liberty projectrangers enterstudio jonasduerto mallykilly bobsilverberg radix tersiasarendse cleitonnaruto darthnoob saadmahboob bradparks hfeliciano63 gabinamalina fullstackenviormentss ohsevin seanwu99 kidusmt southerncharmz zvukoper navneetsinh productinfo 4stgump atomicknight kapokyue shuang920 arc18angels sfsam eleanorprada jared-chang bruna16

ignotifier's Issues

Make toolbar icon blink when there are new messages

Add support of MultiFox add-on

Could you, please, add support of MultiFox add-on?
The thing is that add-on modifies all the cookies by changing their URL that way:
site.com -> site.com.heregolotsofrandomsymbols.multifox-auth-2
mail.google.com -> mail.google.com.heregolotsofrandomsymbols.multifox-auth-2

Thus, your extension says "please log into an account first".

freeze timer until gmail tab gets unloaded/closed.

Check bug #38 for more info.

Opens wrong account

I have v0.1.6 and it opens only the default account even though the other account has the new mail.

LMB click opens wrong address for me

https://accounts.google.com/ServiceLogin?service=mail&passive=true&rm=false&continue=http://mail.google.com/mail/&scc=1&ltmpl=default&ltmplcache=2
instead of
https://mail.google.com/mail/u/0/

Resuse old tab if there is any

Do not open a new tab each time Gmail is called.
https://addons.mozilla.org/en-US/firefox/addon/gmail-notifier-restartless/reviews/408474/

Icon color and function

I think it's better if it were:
gray: none logged-in yet
blue: no new unread mail
red: old unread mail
red + count: new unread mail

This would complement and prepare for a possible future option to assign customizable color combinations (sounds too).

Select Account window position not remembered

When more than one account has new mail we get the Select Account window. It would be nice if it would restore it's previous position on the screen rather than centering every time?

Exchange [disconnected] and [nounreadmail] icons

For me it is way more logical that a gray icon should indicate that there is no connection with the server, or the user hasn't logged into the account.
So please, just exchange the icons for "no unread messages" and "not logged in" states.

Display all accounts at all times

If all accounts, or the one with which I want to compose a new message with, is without any new notifications, I have no 'convenient' way of accessing it.

I'd suggest displaying all accounts upon hoovering the icon at all times. And, if with no new, let there be no count at all, not even a (0).

Custom color selections

Would you consider adding a link to Restore default?

Mail count indicator

better if furthest away from mouse pointer, like top left, if most users have the toolbar at the top and usually approaches the icon from a bottom-to-top motion of the screen.

User's actions should be taken into account by the timer

Opening gmail should reset and freeze the timer until the tab gets unloaded.

Mail preview on tooltip

Adding a preview of new emails to the tooltip of the toolbarbutton.

Facebook integration

Can we have notifications of any Facebook activity?

Convert <SVG> to <label>

object needs to be converted to . Also we need to implement CSS filters instead of SVG filters.

Option's changes need restart to take effect

main.js -> config needs to be updated to support dynamic pref reads.

Separate sounds for accounts

Can we have the option to assign each account their own sound? In X-notifier I was able to do so via the about:config page.

LMB clicking on the popup should open the site

Currently, leftclicking the popup just dismisses it.
I think rightclicking is fine for dismissing popups, but leftclicking should open the mail site.

Add-ons Manager page suggestions

"Gmail Notifier (restartless) supports multiple account Gmail check. To log-in to multiple accounts follow this instruction."

EDIT:
The text "this instruction" is not a link and, coincidentally, the instructions below it does not pertain. if not supported, I'd say - Gmail Notifier (restartless) for single and/ or multiple Gmail accounts. To enable "multi accounts", please search for the quoted text at: http://support.google.com.

Left click: Open Gmail
Middle/right click: Check Gmail(s) for updates

EDIT:
Left click: Opens Gmail
Right click: Account selections
Middle click: Refreshes all accounts

Source Code
Source code is available on Github
To report bugs and track them submit them here

EDIT: here too, the text "here" is not a link, I'd say - To report and track issues, please submit them at: https://github.com/inbasic/ignotifier/issues

Separate feeds by ",".

EDIT:
Shouldn't it actually be comma+space?
I'd say - Separate feeds by ", " (comma + space).

This setting takes place after first restart

EDIT:
I'd say - Restart required - and also include it at the color changing lines

Use alphabetic sort order for accounts

EDIT:
I'd say - Sort account selections alphabetically

Notify only for "Important and unread"

Hey. I would like for the add-on to notify me only when a new email arrives in the "Important and unread section" (but not when an unimportant email arrives). Is that possible?

Add support of private tabs

In the changelog to the last version I've noticed support of private windows, could you also add support of private tabs?
The thing is that private tabs should be ignored, so if a user is logged into 2 Gmail accounts, but 1 of them is logged in in a private tab - whenever the user left-clicks your add-on's button - it should activate a normal tab with the account that the user logged in unprivately.
Currently, your extension just seeks the tab-bar for a tab with gmail and activates it regardless of that tab's privacy state.

Opening inbox should reset the counter on the button

I think that opening inbox and especially opening it via clicking the extension's button/popup should reset the counter on that button to zero.

New email alert sounds when no account logged-in

Right or Middle-click when no accounts are logged-in opens the Gmail Sing in page but also sounds the alert sound.

Mac OS desktop notification doesnt show up

https://bugzilla.mozilla.org/show_bug.cgi?id=594543

Add a choice of the type of notification

I don't like the pop-up: on my pretty modern PC it still very laggy.
I'd prefer icon blinking + sound notification.

Still opening the wrong account

It asks which account to open but still opens the default account even though I clicked the other. It doesn't seem to matter which was the last account accessed.

Alert sounds is silent

I do hear it in Windows control panel

icon blinks when color changes

Toolbar icon blinks when icon image changes.

Bug: Not loaded on startup

Now and then, when I open Firefox, the addon isn't shown in my toolbar. I have to disable and enable the addon for it to show up, or restart Firefox. Why is this and can you fix it, please?

Errors in the console [on Nightly]

Error: gmail-notifier: DEPRECATED: The require("private-browsing") module's "start" and "stop" events are deprecated.
Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 155, in then
    result.then(resolve, reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/addon/runner.js", line 95, in null
    run(options);
  File "resource://gre/modules/commonjs/sdk/addon/runner.js", line 127, in run
    let program = main(options.loader, options.main);
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 353, in main
    return load(loader, module).exports;
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 237, in load
    evaluate(sandbox, module.uri);
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 210, in evaluate
    : loadSubScript(uri, sandbox, encoding);
  File "resource://jid0-gjwrpchs3ugt7xydvqvk4dqk8ls-at-jetpack/gmail-notifier/lib/main.js", line 282, in null
    pb.on("start", function() {
  File "resource://gre/modules/commonjs/sdk/util/deprecate.js", line 32, in deprecateEvent
    deprecateUsage(msg);
  File "resource://gre/modules/commonjs/sdk/util/deprecate.js", line 16, in deprecateUsage
    let stack = get().slice(2);

    Timestamp: 01.04.2013 0:08:15
Error: gmail-notifier: DEPRECATED: The require("private-browsing") module's "start" and "stop" events are deprecated.
Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 155, in then
    result.then(resolve, reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/addon/runner.js", line 95, in null
    run(options);
  File "resource://gre/modules/commonjs/sdk/addon/runner.js", line 127, in run
    let program = main(options.loader, options.main);
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 353, in main
    return load(loader, module).exports;
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 237, in load
    evaluate(sandbox, module.uri);
  File "resource://gre/modules/commonjs/toolkit/loader.js", line 210, in evaluate
    : loadSubScript(uri, sandbox, encoding);
  File "resource://jid0-gjwrpchs3ugt7xydvqvk4dqk8ls-at-jetpack/gmail-notifier/lib/main.js", line 285, in null
    pb.on("stop", function() {
  File "resource://gre/modules/commonjs/sdk/util/deprecate.js", line 32, in deprecateEvent
    deprecateUsage(msg);
  File "resource://gre/modules/commonjs/sdk/util/deprecate.js", line 16, in deprecateUsage
    let stack = get().slice(2);

Disable opening context menu on right-click

Having no middle button, I was happy to learn a right-click also functioned in the same way, check for updates. But, as expected, it opens the context menu. Disabling it when clicking the icon would be nice. I have, however, learned how to configure my Synaptics TouchPad to simulate a middle-click and no longer need to perform the additional step of clicking a blank area to close the context menu. I assigned tapping the top-right-corner of my touchpad.

Toolbarbutton counter font issue in Linux OS

In Linux OS, "+" symbol is not aligned center like in Windows. There should be SVG font issue.

Refreshing mail indicator

I prefer the previous spinning orb, it was much easier to see and also not intrusive

feed urls with labels not works

if i use the regular feed url, https://mail.google.com/mail/u/0/feed/atom the addon works.
but if i wanna that the addon will check an label,
so, url like that: https://mail.google.com/mail/u/0/feed/atom/unread
will not work, i suspect that it because google setts fullcount property to 0 even though there are the correct amount of entities.

Button gets removed from toolbar after browser restart

Having the Site Searcher (https://addons.mozilla.org/firefox/addon/site-searcher/) and Gmail notifier buttons in the same toolbar together, and then restarting the browser, results in the Gmail notifier button getting moved from the toolbar to the "Customize toolbar" dialog.

Select Account sort order

Add the ability to custom sort the accounts in the window, via click-n-drag, possibly.

Errors in the console

I get 4 duplicate errors to the Error Console on browser startup caused by this add-on.

Error: gmail-notifier: An exception occurred.
Traceback (most recent call last):
  File "resource://jid0-gjwrpchs3ugt7xydvqvk4dqk8ls-at-jetpack/api-utils/lib/xhr.js", line 125, in 
    self._orsc.apply(self, arguments);
  File "resource://jid0-gjwrpchs3ugt7xydvqvk4dqk8ls-at-jetpack/gmail-notifier/lib/main.js", line 123, in 
    count = xml.fullcount;
  File "resource://jid0-gjwrpchs3ugt7xydvqvk4dqk8ls-at-jetpack/gmail-notifier/lib/main.js", line 72, in 
    return parseInt(xml.getElementsByTagName("fullcount")[0].childNodes[0].nodeValue)
TypeError: xml.getElementsByTagName("fullcount")[0] is undefined

Middle click alternative

Since some users may not have a middle button (I don't), you may want to add the option to also use Alt+Left click.

Add-ons Manager page to read:

Left click: Opens Gmail
Right click: Account selections
Middle (or Alt+Left) click: Refreshes all accounts

0.2.7 beta breaks icon left-click when multiple accounts have emails

When logged in with multiple accounts, if more than 1 account has an unread message, I can't left-click the icon to access the accounts (right-click still works fine.) If only 1 account has an unread message, left-click works fine. This feature worked in 0.2.6 beta.

RMB should not open a new non-modal window

Instead, you could use just a context menu: that approach doesn't require the user to move cursor far away from the icon that has just been clicked and it doesn't block the content area of the browser (which your extension currently does until you dismiss the window)