Comments (3)
@luqven hi! Thanks for the very quick response, it's very much appreciated 🙏 .
Yes, one easy and quick way for fixing this would be by setting disable_path_encoding
, and I think we could benefit from that change. I'll be happy to provide a PR but currently I think I don't have the capacity for doing it, unfortunately I've been rather busy lately... but I'll try to find some time for it in the next days 🤞
from imgix-rails.
Hey @spaghetticode 👋🏼
I just wanted to give you a big shoutout for all your hard work and for giving back to the community. To say thanks, we'd love to hook you up with some account credit. Please get in touch with [email protected] with your account info and send them a link to this comment. They'll get you set up.
We couldn't do it without people like you, and we are grateful for all you do to make imgix-rails the best it can be!
from imgix-rails.
Hey @spaghetticode, I just noticed this was the "parent" issue.
I can see why this is a breaking change for you. We should have more explicitly communicated that in the release notes and I'll make a note to add a test for URLs that include a ?
in the path so that any future breaking changes there are caught before release.
Looks like to resolve your issues we'd need to expose a way to set disable_path_encoding
globally in imgix-rails
. I can't give you a time estimate as to when, but we'll look into adding this as a configuration option.
Of course we're always open to PRs and if you feel comfortable taking a stab we'd love to provide guidance and feedback.
In the meantime if anyone else would like to see this added please do comment and let us know to help us prioritize this work.
Thanks again for reporting this!
from imgix-rails.
Related Issues (20)
- Updating imgix-rb dependency to v4? HOT 2
- ssrf external service interaction to malicious external source - security issue HOT 8
- Usage with multiple sources? HOT 1
- Multiple secure_url_tokens when using multiple sources HOT 3
- max_width not working HOT 4
- Support Multiple Sources HOT 4
- data-srcset instead of srcset HOT 5
- Switching between dev (local filesystem) and production (aws s3) HOT 2
- SemVer? Changelog? HOT 4
- ix_picture_tag provides wrong ouput of v3 HOT 1
- extra srcset link generated causes issue on non-retina displays HOT 1
- bundler restricted to version <2.0
- ActiveStorage support HOT 5
- Support latest version of imgix-rb HOT 1
- How to use inside a model? HOT 9
- `min_width` and `max_width` are rendered to HTML tag HOT 1
- Digest hash HOT 3
- Getting static image instead of GIF HOT 4
- data attributes instead of plain srcset, src, sizes attribute HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imgix-rails.