imelgrat / barcode-validator Goto Github PK

View Code? Open in Web Editor NEW

20.0 3.0 14.0 688 KB

A PHP class for validating EAN, IMEI, ISBN, GTIN, SSCC, GSIN, UPC and other similar codes.

License: MIT License

PHP 100.00%

validation ean13 ean ean8 ean-code upc-a upc-e isbn isbn-number imei

barcode-validator's People

Contributors

Stargazers

Watchers

Forkers

ftshp gmatsov hithomasmorelli gituu4567 tashlykov ajsultandev micsedinam musikster calvera 5l1v3r1 dobefu vzaichikov amirtheahmed jonasjelonek

barcode-validator's Issues

length should not invalidate bar code.

i have encountered manufacturers who are using a 2 digit suffix at the end of the 12 digit UPC bar code. the 2 digit suffix indicates a packaging of some sort. you are returning false if the length is not the expected length.

barcode-validator/src/BarcodeValidator.php

Lines 71 to 72 in 6512e3b

 // Check if the string length matches the code's desired length 

 if (strlen($code) == $length) {

here is one such code: 84788101273501

upczilla does validate this code as true while your validator automatically returns false.

Update version number

Commit e41cc18 contains crucial fix for check digit validation but version was not increased since then.
This means that composer install for newest version contains wrong check digit algorithm which thinks that 5050953104518 is valid Ean13 but in fact 5050953104510 is.

Does not work for ISBN 13 and UPC codes

Hey,
your code does not work with common ISBN 13 and UPC codes. Try followings

ISBN: 9780241235645
UPC: 883929344130

Works with ISBn 10 e.g.
1870089049

Thanks

Publish new version to packagist

Hi, is it possible to push version 1.1.2 to packagist?
The version that composer is downloading is 1.1.1.

Thanks

Autoload not working

The problem

I installed the library with composer.
Composer's autoload.php is included correctly.
When I call \BarcodeValidator::IsValidUPCA(), I get class \BarcodeValidator not found.

Possible solution

Upon investigation, I found that the class is written in a barcode-validator.php, while usually it should be BarcodeValidator.php for the composer's autoload to work 🤔
I copied the file to BarcodeValidator.php and it gets auto-loaded correctly.

small fix

		public static function IsValidIMEI($code = '')
		{
			// Remove hyphens
			$code = str_replace('-', '', $code);
			if (preg_match('/^[0-9]+$/', $code)) {
				switch (strlen($code)) {
					case 14: // No check digit. always true
						return true;
						break;
					case 15: // IMEI number with check digit. Test check digit
						return BarcodeValidator::validateLuhnCheckDigit($code, 15);
						break;
					case 16: // It's a IMEISV code (IMEI Software Version). No check digit
						return true;
						break;
					default: // +
						return false; // +
				}
			}
		}

imelgrat / barcode-validator Goto Github PK

barcode-validator's People

Contributors

Stargazers

Watchers

Forkers

barcode-validator's Issues

length should not invalidate bar code.

Update version number

Does not work for ISBN 13 and UPC codes

Publish new version to packagist

Autoload not working

The problem

Possible solution

small fix

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// Check if the string length matches the code's desired length
	if (strlen($code) == $length) {