imahjoub / hash_sha256 Goto Github PK

Hi Iliass (@iaitelmahjoub)

I'm checking the command line here.

The command line to compile/link is a bit easier/different. I think the command-line flags are a bit mixed up.

A command like this for compile/link might work better.

g++ -mtune=native -march=native -O2 -Wall -Wextra -Wconversion -Wsign-conversion -std=c++17 -fno-inline-functions -fprofile-arcs -ftest-coverage hash_sha256_test.cpp -I. -o hash_sha256_test.exe

In YAML, this will look like the following:

${{ matrix.compiler }} -mtune=native -march=native -O2 -Wall -Wextra -Wconversion -Wsign-conversion -std=${{ matrix.standard }} -fno-inline-functions -fprofile-arcs -ftest-coverage hash_sha256_test.cpp -I. -o hash_sha256_test.exe

Hi Iliass (@imahjoub) I notice that the "try it on Godbolt" button links to code that fails compile.

This link is one potential solution that repairs it. There are several possible ways to repair and i'm not sure which one you like. That link does link to one possible correciotn.

Nice work on this repo iliass.