imaginativeshohag / why-not-image-carousel Goto Github PK

Please add an attribute to change indicator color. I have tried foregroundTint an backgroundTint but it's not changing the color.

Hi there , first i'm sorry for my bad English!
i'm using this library and it is good , but LOOP slide is not supported. can you make this possible please?
i want like this:
img1 > img2 > img3 > img4 > img1 > img2 ...

Images are not loading when trying to find the carousel with viewBinding, example

class MainActivity : AppCompatActivity() {

    val listaImagenes = mutableListOf<CarouselItem>()
    private lateinit var binding:ActivityMainBinding

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)
        binding = ActivityMainBinding.inflate(layoutInflater)
        listaImagenes.add(CarouselItem(imageUrl = "https://imgcla.lavoz.com.ar/files/imagecache/ficha_aviso_mobile_462_253/avisos/aviso_auto/aviso-auto-ford-ka-7528636.jpg"))
        binding.carousel.addData(listaImagenes)
    }
}

Output

Tried app:carouselType="SHOWCASE" attribute in xml, but its showing the carousel in Block style.

Hi ,I've just seen this amazing library,but I've encountered problems when importing it.
Could not find org.imaginativeworld.whynotimagecarousel:whynotimagecarousel:1.2.1. Required by: project :app

Anything I'm doing wrong?

When calling .setData(list) with empty list - for example when users update pictures in the gallery - library crashes with the following error.

Originally when Carousel started empty - it shows empty picture as expected, when later setiing some pictures and set it again with empty list following error is thrown.

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: fit.jeem.stage, PID: 15814
    java.lang.ArithmeticException: divide by zero
        at org.imaginativeworld.whynotimagecarousel.adapter.InfiniteCarouselAdapter.getRealDataPosition(InfiniteCarouselAdapter.kt:38)
        at org.imaginativeworld.whynotimagecarousel.ImageCarousel$initListeners$1.onScrolled(ImageCarousel.kt:819)
        at androidx.recyclerview.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:5347)
        at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:4405)
        at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4031)
        at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4578)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1873)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1873)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1873)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
        at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
        at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
        at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
        at android.view.View.layout(View.java:21912)
        at android.view.ViewGroup.layout(ViewGroup.java:6260)
        at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
        at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
        at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)

Hello Shohag you are very broad hearted . This carousel looks amazing but it crashes while lunching. Is there any mistake I did.

is there any way to make transition slower/faster in carousel?

I'm using this after setting data, but it change position fast and keep doing it for all positions like it's working with autoPlay = true.

The carousel is setted like this::
binding.cardListL.carousel.autoPlay = false
binding.cardListL.carousel.infiniteCarousel = true

List list = new ArrayList<>();

// Image URL with caption
list.add(
new CarouselItem(
"https://images.unsplash.com/photo-1532581291347-9c39cf10a73c?w=1080",
"Photo by Aaron Wu on Unsplash"
)
);

I want to use a custom CarouselItem model to add new fields for the carousel.setData(list).

eg.
new CarouselItem(
"imageUrl",
"caption",
"type",
"action",
...
)

Hello sir, i use this library for image carousel
can add color for shadow bottom or top?

thank you

title says it all :)
great library overall!!!

1. Setup autoPlay = true
2. Have more than 1 image.

We are waiting for 1 slide auto-scrolling, we move our finger to the next slide, and auto-scrolling does not work anymore. It starts working if you click on the slide.

I put it in the two ways that are in the repository and neither works, any solution for this error?

I receive Wrong position indexes on onScrollStateChanged !
The values are about the MAX_SIZE of integer (1073741823) !!
I should use position-1073741823 to make it work! (position 0 is OK)

What's the issue?

Hello Team,

super job, i like it.

can you please say me, how can i load from drawable, also not from URL?

I try following but not working

  String s1 = "drawable://" + R.drawable.s1;
    String s2 = "drawable://" + R.drawable.s2;

    for (int i = 1; i <= max; i++) {
        if (i % 2 == 0) {
            list.add(
                    new CarouselItem(
                            s1,
                            "Image " + i + " of " + max
                    )
            );
        } else {

.......
..........

thanks

Hi, I'm trying to use this awesome library in a RecyclerView. Almost everything is ok but after the RecyclerView item - that contains a carousel in it - gets unbound and then again comes in the view and shows up, the CircleIndicator2 view gets disappeared.
I also got this error: The first view is not found! Maybe the app is in the background. and found out it's because of the infinite scrolling being enabled and turning it off apparently prevents the error but I actually want to use the infinite scrolling feature.
I think these two are related. I don't know if the carousel is ok to be used in the RecyclerView or not but I want to know if there is anyway to solve this problem?

I am trying to do this

Handler().postDelayed({
                carousel4.currentPosition = 1
            }, 5000)

but it not moving to position 1
please check that

??

In the documentation for the library, there is a minor grammatical error in the line "The library is now supported infinite carousel." This error can cause confusion for users and negatively impact the overall quality of the documentation. I kindly request a correction to the wording to accurately reflect the functionality of the infinite carousel feature.

why autoplay not working?

Not sure if library is supporting something like this. But in readme instructions there was a sample related to this.

can you give us an example for this code

// Item click listener
carousel.onItemClickListener = object : OnItemClickListener {
    override fun onClick(position: Int, carouselItem: CarouselItem) {
        // ...
    }

    override fun onLongClick(position: Int, dataObject: CarouselItem) {
        // ...
    }

}

on c#?
thanks

Cool Stuff you got here ,
Why not give it a try?

You see ... I tried adding this inside project's app.gradle

implementation 'me.relex:circleindicator:2.1.4'
    implementation 'com.github.ImaginativeShohag:Why-Not-Image-Carousel:v1.1.0'

And this is the error it produces when added and synced ...

ERROR: Manifest merger failed : uses-sdk:minSdkVersion 19 cannot be smaller than version 21 declared in library [com.github.ImaginativeShohag:Why-Not-Image-Carousel:v1.1.0] C:\Users\<CurrentUser>\.gradle\caches\transforms-2\files-2.1\a29be6796303cd41d21e68d8a6dd501a\Why-Not-Image-Carousel-v1.1.0\AndroidManifest.xml as the library might be using APIs not available in 19
	Suggestion: use a compatible library with a minSdk of at most 19,
		or increase this project's minSdk version to at least 21,
		or use tools:overrideLibrary="org.imaginativeworld.whynotimagecarousel" to force usage (may lead to runtime failures)

What could possibly be the issue? Should I use tools:overrideLibrary="org.imaginativeworld.whynotimagecarousel"

PS: I have already migrated to Android X

Hello ... Thanks a lot for awesom lib. I have checked several lib but this one is supperb.

I'm using this library it works fine then I found that if we used @style/Theme.AppCompat.Light.NoActionBar then it gives error #15 but if we used @style/Theme.MaterialComponents.Light.NoActionBar then we can resolved the issue.

In my case I have several dependency on my project for AppCompat Theme. I tried to change it to MaterialComponents but it break by app design (mostly happen on InputTextLayout).

Can we used this library by using AppCompat Theme. If there any work arround I would love to do it, any how I want to use this lib in my project.

Please let me know about it.

Thanks

Hello,

I noticed there is a problem while loading photos that are dynamically changing and when the photo list may contain only one item. So, for example, when the photos are pulled from some API.

Consider such a case:
When the photo list contains only one item, you programmatically change the "infiniteCarousel" flag to "false", because there is no point in looping one photo infinitely, so the carousel should behave like one static photo.

Otherwise, when the photo list contains more than one item, you set the "infiniteCarousel" flag to "true", because that is the default and desired behavior.

The problem is that changing this flag programmatically does not reinitialize the adapter, thus this change is not noticed by the carousel at all (in terms of displaying photos).
After changing "infiniteCarousel" flag, you need to change another variable (imageScaleType, imagePlaceholder or autoWidthFixing) if you want this change to take place. I mean invoking initAdapter() method.

I think that changing the "infiniteCarousel" flag programmatically should reinitialize the adapter, so the carousel can behave as I described.

Thank you in advance for your feedback and have a great day!

Best regards,
varchar20

I have tried to change the color of the caption but have not been able to.

• show previous and next image ? (example last carousel )
• fix image size in center and left and right image

I want to add adjustViewBound property.

[Environment]
Android Target SDK: 30
Why-Not-Image_Carousel version: 2.0.2
Three Carousel items.

When Position is 0 (received from CarouselOnScrollListener), there is a conditions that blocks left swipe performed.
I want to move it to the rear when Position is 0.
Is there any way to fix it?

hello. It works perfectly with photographs, but how can I put a carousel of texts? Thank you

Hi, First of all the library is awesome. I love how easy it is to implement it. As you can see my problem from the attachment. There are weird black spaces that fills up and becomes a sharp edged rectangle. But I wanted rounded corners. Can you please provide me a solution on how to fix this?

Edit: If i use image with rounded corners, it fills the gap with black color as seen in the attachment
if i use image with sharp corners like normal images then the carouel view has straight pointy corners and not the rounded corner style.

I have used the same "Theme.MaterialComponents.Light.NoActionBar" as my app theme.

Please let me know if i need to share any file for reference to fix the issue.

After scroll recycle view autoplay stop to work.

style:

    <item name="autoPlay">true</item>
    <item name="autoPlayDelay">1500</item>
    <item name="carouselType">SHOWCASE</item>
    <item name="scaleOnScroll">true</item>
    <item name="infiniteCarousel">true</item>
    <item name="showBottomShadow">false</item>
    <item name="showCaption">false</item>
    <item name="showIndicator">false</item>
    <item name="showNavigationButtons">false</item>
    <item name="showTopShadow">false</item>
    <item name="touchToPause">true</item>
    <item name="carouselGravity">CENTER</item>
    <item name="scalingFactor">0.25</item>

OnBind

           carousel.registerLifecycle(lifecycle)
           carousel.setData(establishment.listImages) //listImages as CarouselItem

Video example
https://user-images.githubusercontent.com/62159705/212760201-e043c51c-837b-4bd1-afe3-ae27c7d8bde6.mp4

Console error
E/ImageCarousel: The first view is not found! Maybe the app is in the background.

Crashes on open with InvocationTargetException Error for view
Process: com.team.shareware, PID: 29716

android.view.InflateException: Binary XML file line #57 in com.team.shareware:layout/product_card_layout: Binary XML file line #57 in com.team.shareware:layout/product_card_layout: Error inflating class org.imaginativeworld.whynotimagecarousel.ImageCarousel
Caused by: android.view.InflateException: Binary XML file line #57 in com.team.shareware:layout/product_card_layout: Error inflating class org.imaginativeworld.whynotimagecarousel.ImageCarousel
Caused by: java.lang.reflect.InvocationTargetException
    at java.lang.reflect.Constructor.newInstance0(Native Method)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:343)
    at android.view.LayoutInflater.createView(LayoutInflater.java:858)

Auto play with various numbers of delay didn't work, I was trying on android 10 real device

 carousel.autoPlayDelay = 150
 carousel.autoPlay = true

If the carouselGravity sets to START it will try to scroll to the next item then go back to the first item immediately.
If the carouselGravity sets to CENTER the distance between items is messed up.

Hi guys,

thanks Mahmudul Hasan for your simple and awesome image slider,

I want to pause the auto sliding until i release my finger from the slider, there is a way to do this with this lib??

thanks

I have android:theme="@style/Theme.AppCompat.Light.NoActionBar" then this code is not working please make it work without action bar

I have a Carousel with app:carouselType set to "SHOWCASE" and app:carouselGravity set to "CENTER". Currently on swiping through the carousel long enough, it scrolls through multiple CarouselItems. How do I ensure that the user can only scroll through the carousel one CarouselItem at a time?

Hi! i need to load images from a URL that needs an authentication heather, its is posible some way? or its it possible to add a custom CarouselAdapter? thanks!

CarouselType.SHOWCASE not working

Why type SHOWCASE always show type BLOCK ?

Hello,

is it possible to view thumbnails of the images?

Thank you

I've looked at the implementation

ImageCarousel.kt

fun addData(data: List<CarouselItem>) {
        adapter?.apply {
            addAll(data)
            [email protected] = data
            [email protected] = data.size
            initOnScrollStateChange()
        }
    }

CarouselAdapter.kt

fun addAll(dataList: List<CarouselItem>) {
        this.dataList.clear()

        this.dataList.addAll(dataList)
        notifyDataSetChanged()
    }

As you can see that calling addData will not just adding data, but clear all previous data too. It should be called setData, submitData, or maybe replaceData.

Or you can have both, addData and setData.

Hi
Thanks for the library
When we set data at first time, it correctly shows indicator at first position, but if we reset new data with the same setData method, indicator gets hidden, and shows after manual scrolling

First time

Second time

Is there any way to implement loading animation when loading images?