Git Product home page Git Product logo

git-version-lite's People

Contributors

bradyclifford avatar cbchadb35 avatar danielle-casella-adams avatar dependabot[bot] avatar dougdyreng avatar hpractv avatar joemcbride avatar jordanzaerr avatar josephdschwartz avatar mike-schenk avatar

Stargazers

avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

jordanzaerr im-customer-engagement joemcbride migonza bradyclifford forky-asks-a-question gherpin

git-version-lite's Issues

`create-ref` feature is inconsistent with the load search behavior and tags the "wrong" commit sometimes.

The version calculation code looks at commits from the current working directory's HEAD back to the prior applicable sever tag. However, the create-ref behavior completely ignores the current HEAD and picks the commit to tag based on the current workflow's triggering event. In the case of a pull-request trigger, it always creates that ref against the tip of the pull requests' branch and never the merged result.

This action should either

  • not have a create-ref feature, or
  • create the ref against the same commit on which the next version calculation is based, namely the HEAD of the current working directory.

Create-ref behavior:

git-version-lite/src/main.js

Lines 25 to 28 in d7329dd

const git_sha =
github.context.eventName === 'pull_request'
? github.context.payload.pull_request.head.sha
: github.context.sha;

Version incrementing history search:

git-version-lite/src/version.js

Line 141 in d7329dd

releaseType = determineReleaseTypeFromGitLog(baseCommit.abbreviatedCommitHash, 'HEAD');

git-version-lite/src/version.js

Line 167 in d7329dd

let currentHeadCommit = git.commitMetadata('HEAD');

git-version-lite/src/version.js

Line 180 in d7329dd

releaseType = determineReleaseTypeFromGitLog(baseCommit.abbreviatedCommitHash, 'HEAD');

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.