ilyalozovyy / credentialmanagement Goto Github PK

I am using the NuGet CredentialManagement package in a .NET6 project (Target OS Windows; Build x86). When compiling I get the following error message:

warning NU1701: Package 'CredentialManagement 1.0.2' was restored using '.NETFramework,version=v4.6.1, .NETFramework,version=v4.6.2, .NETFramework,version=v4.7, . NETFramework,version=v4.7.1, .NETFramework,version=v4.7.2, .NETFramework,version=v4.8, .NETFramework,version=v4.8.1' instead of the project target framework 'net6.0-windows7.0'. This package may not be fully compatible with your project.

Questions:

1. Can I ignore this error message?
2. Does CredentialManager no longer work properly on .NET6?
3. Do I still need an installed .NET Framework 4.8.1 in addition to the .NET6 runtime?

Greetings Chris

Credential.cs marshals a string on line 228:

      `credential.CredentialBlob = Marshal.StringToCoTaskMemUni(Password);`

Does the unmanaged memory need freeing afterwards, such as

      `Marshal.FreeCoTaskMem(credential.CredentialBlob);`

?

in your nuget page the project page point to old archived codeplex page :
https://www.nuget.org/packages/CredentialManagement/1.0.2?_src=template

they point to : https://credentialmanagement.codeplex.com/

can you change to link to this projet (https://github.com/ilyalozovyy/credentialmanagement) on github ?

Hi.

Whenever a Win32API fails and SetLastError set to true on the DLL import, it's possible to add get the actual error.

referred code:

Possible way to get the actual error:

int lastError = System.Runtime.InteropServices.Marshal.GetLastWin32Error();
var message = String.Format("'CredWrite' throw an error (error code: {0})", lastError);
throw new Win32Exception(lastError, message);

Thanks.

@ilyalozovyy -
Can you please accept and commit my PR?