ijwu / enemizer Goto Github PK

Steps on Linux release:
Either:
1a. unzip ubuntu.16.04-x64.7z; OR
1b. 7z x ubuntu.16.04-x64.7z; then in either case,
2. Run WebHost (or, attempt to run Enemizer another way)
Bug: PermissionError: [Errno 13] Permission denied: '/home/username/archipelago/EnemizerCLI/EnemizerCLI.Core'
Expected: No exception, able to roll seed

The file is not executable (missing 'x'):

$ ls -l EnemizerCLI/EnemizerCLI.Core
-rw-r--r-- 1 username username 90712 Dec 11  2020 EnemizerCLI/EnemizerCLI.Core

Workaround is to manually set executable permission on the file that drew the exception.

Release should employ a way to have the needed files be marked as executable in the Linux release. This may be possible in the .zip or .7z, or alternatively this is supported well in .tar.gz.

With Key Drop Shuffle enabled, if Moblins are placed in a key drop location, the game crashes when they are killed.
Long ago I wrote this code to check for Moblins on these locations and replace them:
https://github.com/Alchav/Archipelago/blob/6d798cc75d72c47ba234f2cc290e119b59d67da9/worlds/alttp/Rom.py#L431

It looks to me like this could be fixed rather easily in Enemizer by adding SetCannotHaveKey() to the Moblin on line 344 in SpriteRequirement.cs, but I am not set up to compile/test this.

The release json EnemizerCLI.Core.deps.json reports 7.0.1 for the 7.1.0 version, which is what Archipelago uses to verify version, failing version check to see if Enemizer would break a "oof sound" rom such as from ArchipelagoMW/Archipelago#709.

The 7.0 release still reports 6.4.0 in EnemizerCLI.Core.deps.json -> "EnemizerLibrary": "6.4.0" (Which AP uses to check version)
As well as in EnemizerVersion.json

This for now blocks AP from making use the now accepted romnames, as it can't ensure that the user updated.