ihorvitruk / buddysearch Goto Github PK

In module presentation, class App, your method intializeInjector()

You have appComponent = DaggerAppComponent

in the import statements it shows its supposed to be in the

import com.buddysearch.android.presentation.di.component.DaggerAppComponent;

only see ActivityComponent and AppComponent

In the entities/realm, the classes extend RealmObject. Isn't this a violation of the dependency rule?

This question will have more to do with the pattern than with this example of implementation.

I'm trying to understand the clean architecture, and getting in touch for the first time with RxJava and injection dependencies.

Considering that it'll take me even longer to understand all this, I'd like to know before starting to use this project as a base if I could use this pattern for the development of my application, all the functionality of the application (or most of it) will be Based on a map, and from certain conditions such as the user's position, one functionality or another will be available. Very similar to the way Google Maps works. My doubt arises more than anything because I consider that all the functionality of the map could be done in the same activity, and specific things like the entrance of users could be handled in other activities and I don't know if the clean architecture will complicate things more for me (I'm beginner) .

All this is for the sake of implementing an architecture that allows other developers to integrate into the future in the project and quickly.

regards

In Data module manager/impl AuthMangagerImpl you have saveUser(FirebaseUser user, Subscsriber subscriber)

There you create a new UserDto and call setId.

The only set Id i found was from Entity, am I doing something wrong, the code won't compile for me?

Should there be getters and setters for the Dto?

You shouldn't use any data layer specific model in Presenters.

LoginPresenter uses GoogleSignInAccount objects, which is specific to the Login SDK you chose, but this dependencie should not be visible inside the presenter.
This violate the Clean Architecture boudaries.

If you study Uncle Bob's clean architecture layers, you can see that the Presenters are one level below the data layer, so the models can't be shared between them if it's a data layer's model.

You place all classes with same type into same group. ie presenter classes are under /presenter package, activities are under /activity package, ...
1 question: How will you manipulate them in real project where you may have many activities, fragments, views, presenters,...?

First of all I want to thank you for this demo showing how to implement Clean Architecture using MVP in combination with Dagger2 and other useful tools.

I have noticed that the following issue with the current implementation:
The presenter object creation in BaseActivity#onCreateLoader() could create memory leaks.

Do you intend to implement the MVVM pattern and eliminate the use of Loader?

BaseActivity should declare the generic type for BasePresenter also. It should be:

public abstract class BaseActivity<VIEW extends View,
        PRESENTER extends BasePresenter<VIEW>,
        BINDING extends ViewDataBinding> extends AppCompatActivity
        implements LoaderManager.LoaderCallbacks<PRESENTER> {

This will also fix any issues with: "Unchecked call to as a member of raw type"

In Android Studio 3.0.1 project build fails, update gradles, dependent libraries to be able to build in new AS.

I have seen that you have used Domain layer components in Data layer
as per clean architecture Data layer component should not be used in Data layer component

Hello,

This project is very nice for learning purposes, but I encountered an blocking issue.
I need to use Flowable on a stream of data and the Use case of the domain interactor relies only on Observable. How do you recommend to approach this limitation?