Git Product home page Git Product logo

yaapii.xambly's People

Contributors

avexcaesar avatar edjopato avatar fneu avatar herickj-22 avatar icacle avatar icaobu avatar koeeenig avatar meerownymous avatar mse1188 avatar pz1337 avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

yaapii.xambly's Issues

Unittest for Directives

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

We have a unittest.

Actual Behavior

No Unittest.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Migrate to Atoms 0.5.9

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Xembly uses Atoms 0.5.9

Actual Behavior

It uses 0.5.8

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Make ANTL4 Parser work

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

ANTL4 Parser is ready but not integrated.

Actual Behavior

ANTL4 Parser works

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Remove build warnings

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

No warnings when compiling.

Actual Behavior

Still warnings:

Severity	Code	Description	Project	File	Line	Suppression State
Warning	CS3021	'XemblyBaseListener' does not need a CLSCompliant attribute because the assembly does not have a CLSCompliant attribute	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Antlr4\XemblyBaseListener.cs	44	Active
Warning	CS3021	'XemblyLexer' does not need a CLSCompliant attribute because the assembly does not have a CLSCompliant attribute	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Antlr4\XemblyLexer.cs	40	Active
Warning	CS3021	'IXemblyListener' does not need a CLSCompliant attribute because the assembly does not have a CLSCompliant attribute	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Antlr4\XemblyListener.cs	40	Active
Warning	CS3021	'XemblyParser' does not need a CLSCompliant attribute because the assembly does not have a CLSCompliant attribute	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Antlr4\XemblyParser.cs	43	Active
Warning	CS0162	Unreachable code detected	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Directive\Directives.cs	431	Active
Warning	CS0162	Unreachable code detected	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Directive\Directives.cs	490	Active
Warning	CS0168	The variable 'ex' is declared but never used	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Xembler.cs	127	Active
Warning	CS0168	The variable 'ex' is declared but never used	Yaapii.Xml.Xembly	C:\Users\csa\Source\Git\Yaapii.Xembly\src\Yaapii.Xml.Xembly\Xembler.cs	132	Active

Steps to reproduce the behavior

Build

The log given by the failure.

Mention any other details that might be useful

Unittest for Popdirective

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

We have a unittest.

Actual Behavior

No Unittest.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

new class XmlDocumentOf

I Modified AddDirective.

I created a class for retrieving XmlDocument from Node which encapsulates your solution. But I realized that we appearantly do not need the else if, because the msdn says:

Wenn der Knoten ein XmlDocument ist (NodeType ist gleich XmlNodeType.Document), gibt diese Eigenschaft null zurück.

Agreed @koeeenig ?

Downgrade to antlr 4.6 for usage in Tecnomatix

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Actual Behavior

Tecnomatix uses .Net 4.6.1 which cannot use ANTLR 4.7.

Steps to reproduce the behavior

Xembly uses ANTLR 4.6 which is available for .Net 4.6.1.

The log given by the failure.

Mention any other details that might be useful

Unittest for XPathDirective

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

We have a unittest.

Actual Behavior

No Unittest.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Must Xembler.Apply() be threadsafe?

We can modify directives and Apply() is not affected.

Is this possible?

Another solution could be that we use the (yet not existing) copyof method, which then should be threadsafe.

But lets discuss, if this is needed or not.

AppVeyor: Not generating ANTLR4 files

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

ANTLR4 files are generated, the AppVeyor executes the PreBuild event whic is defined in Yaapii.Xml.Xembly.csproj

Actual Behavior

Parser files are not generated. They are included manually now.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

  • Maybe the PreBuild event is not triggered by DotNetCoreBuild in cake (simulate this locally?)
  • Maybe the Environment variable for Java is not coreectly set, so that we have to adjust our PreBuild event

Make a pre build event which trigger ANTLR4 compiling

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

When I change the xembly.g file which is an ANTLR4 source file, the ANTLR4 compiler is triggered and my C# classes are being updated.

Actual Behavior

I have to trigger the compilation manually.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

To trigger the compiler, navigate into project root and call from commandline:
java -jar tools/antlr-4.7-complete.jar -Dlanguage=CSharp .\src\Yaapii.Xml.Xembly\Antlr4\Xembly.g

Java 1.8 is needed.

Correct Test Namespaces

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Most Tests have the namespace Yaapii.Xml.Xembly.Tests.Directive
some have the namespace Yaapii.Xml.Xembly.Directive.Tests

I think to remeber we said the last one should be used, right?

Actual Behavior

Mixed namespace

Steps to reproduce the behavior

https://github.com/icarus-consulting/Yaapii.Xembly/blob/f0350ac1312451c27f32b0814cb2a713fba01bf1/tests/Yaapii.Xml.Xembly.Tests/Directive/DirectivesTest.cs#L14

https://github.com/icarus-consulting/Yaapii.Xembly/blob/f0350ac1312451c27f32b0814cb2a713fba01bf1/tests/Yaapii.Xml.Xembly.Tests/Directive/PopDirectiveTests.cs#L8

The log given by the failure.

Mention any other details that might be useful

Comment XmlDocumentOf

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Comments like in PR #49

Actual Behavior

No comments.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

AddDirective ignores namespace

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Directive considers xml namespaces

Actual Behavior

namespaces are ignored

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Comment SynchronizedCollection

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Comments like in PR #49

Actual Behavior

No comments.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Migrate to Atoms 0.5.8

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Project references Atoms 0.5.8

Actual Behavior

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

AddDirective fails on XmlDocument

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Add directives to a given XmlDocument

Actual Behavior

Throws Yaapii.Xml.Xembly.ImpossibleModificationException

Steps to reproduce the behavior

var doc = new XmlDocument();
new Xembler(
    new EnumerableOf<IDirective>(
                new AddDirective("root")
             )
    ).Apply(doc);

The log given by the failure.

Yaapii.Xml.Xembly.ImpossibleModificationException: 'Exception at dir 1: Yaapii.Xml.Xembly.AddDirective'

Mention any other details that might be useful

In the AddDirective The XmlNode dom element is null at OwnerDocument if it is of type XmlDocument.. There fore a new XmlDocument is created as dom element. https://github.com/icarus-consulting/Yaapii.Xembly/blob/b44eae162e96205f6733a47a48bcf91a21caa187/src/Yaapii.Xml.Xembly/Directive/AddDirective.cs#L30-L34

If is pass in a XmlNode into the Apply-Method everything works fine.

Integrate third party library to use XPath 2.0. or 3.0

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

We have XPath 2.0 or 3.0

Actual Behavior

Microsoft C# only supports XPath 1.0

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

  • Saxon: XPath 3.1, XQuery 3.1, XSLT 3.0
  • XmlPrime: XPath 3.1, XQuery 3.1, XSLT 2.0
  • QueryMachine: XPath 2.0, XQuery 1.0
  • Lightweight XPath2 for .NET: XPath 2.0
  • Exselt: XSLT 3.0

Directives.Xset(): Remove NotImplementedException and implement the Code

This Issue depends on issue #20

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

The code works as its designed

Actual Behavior

https://github.com/icarus-consulting/Yaapii.Xembly/blob/b59b9e11f0ed1edc3a0953a12fe293dcb8ca8f6f/src/Yaapii.Xml.Xembly/Directive/Directives.cs#L428-L445

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Make Directives accept Atoms IText

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Directives accept IText

Actual Behavior

Directives accepts only string

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Add Cake Build script

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Cake Build script exists.
Steps are:

  • Clean
  • Restore
  • Build
  • Test
  • Pack
  • Release

Actual Behavior

No build script for Build server exists

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

The build script is similar to icarus-consulting/Yaapii.Deployment

Unittest for Pushdirective

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

We have a unittest.

Actual Behavior

No Unittest.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Add an Directive to add comments

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

There is an Directive e.g. AddComment() to add comments

Actual Behavior

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Directives.Strict(): Remove NotImplementedException and implement the Code

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

The code works as its designed

Actual Behavior

https://github.com/icarus-consulting/Yaapii.Xembly/blob/b59b9e11f0ed1edc3a0953a12fe293dcb8ca8f6f/src/Yaapii.Xml.Xembly/Directive/Directives.cs#L486-L491

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

This Issue Depends on issue #14

Add missing MIT License header and missing comments

Bug Report or Feature Request (mark with an x)

  • bug report -> please search issues before submitting
  • feature request

Expected Behavior

Add MIT License in all files:

// MIT License
//
// Copyright(c) 2017 ICARUS Consulting GmbH
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

And add missing comments in some files.

Actual Behavior

Missing License and missing comments.

Steps to reproduce the behavior

The log given by the failure.

Mention any other details that might be useful

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.