ibrahim-mubarak / define-env Goto Github PK

Right now, if a variable is present in System ENV, that variable is completely removed from the dart define string.
However, the variable should be present in dart define string if it's mentioned in the env file

    <configuration name="main.dart" type="FlutterRunConfigurationType" factoryName="Flutter">
      <option name="filePath" value="$PROJECT_DIR$/lib/main.dart" />
      <method v="2" />
    </configuration>

define-env doesn't auto add additionalArgs if this key missing.

I have been error in windows 10, in macOS is good

Using define_env -a configname replaces existing args improperly

--release and --vmservice-out-file becomes
--relea e and --vm ervice-out-file

This is probably due to improper substitution

This is useful when the env files are generated from another tool such as doppler and has to be piped directly to define_env
This can be extremely useful when using this CI/CD Tools

On CI (docker unix image but I'm able to reproduce on windows Powershell), I'm using this tool like that:

flutter build web $(flutter pub run define_env -f "env/.staging.env")

Everything is working fine if .staging.env file doesn't contains space but it's failing each time there is one (KEY="VALUE WITH SPACE" for example)

It's exactly the same than that issue: flutter/flutter-intellij#4588. After some investigation, I think I understand why, but can't figure out how to fix it. The output of the command in interpreted as a string, and the flutter build/run command is not working fine in these cases.

Relevant working samples:

flutter build web --dart-define=KEY1=VALUE1 --dart-define=KEY2="VALUE2 WITH SPACE"
flutter build web '--dart-define=KEY2="VALUE2 WITH SPACE"'
flutter build web '--dart-define=KEY1=VALUE1' '--dart-define=KEY2="VALUE2 WITH SPACE"'

Relevant NOT working samples:

flutter build web '--dart-define=KEY1=VALUE1 --dart-define=KEY2="VALUE2 WITH SPACE"'
=> output "Target file "WITH" not found."

The thing is I'm not sure I can raise an issue to flutter team as the command line argument is not designed to be inserted between quotes. I think the real issue is on the way "define_env" is outputing the result.