ibm / guestbook Goto Github PK

We should add a service that displays pictures from an external service to enhance demos that make connections to third party services. This will also aid istio examples where we show fallback responses during timeouts.

Please change the names of your slave deployments. BLM

for deliveries of the workshop content on non x86_64 platforms (e.g. ICP on POWER and z and OpenShift on POWER), it would be very good for the guestbook container images to be multiarch.

Dockerfile images for redis and busybox need to be updated to take advantage of multiarch container images on docker.io.

Unable to download this image.

Tried directly pulling using docker pull image but getting the below error:

docker pull redis-slave:v2
Error response from daemon: pull access denied for redis-slave, repository does not exist or may require 'docker login'

We should remove duplicated deployment files and add all components for each service into 2-3 larger deployments.

because of the way the app works,

redis-master should be called, either redis or redis-write

redis-slave should be called redis-read

Hello,
I am a OpenShift developer advocate and been using guestbook in my tutorial/webinars where I use OCP on IBM cloud.
I used guestbook in some demos using OCP on ibm cloud (x86) but there are reuqests to run the same demo over OCP on PowerVS (Power Virtual server) in IBM cloud.. I don't see guestbook ppc64le image...hence this RFE.

It would be great to have a ppc64le docker images for v1 and v2 in the docker hub

I follow the instruction guide, https://courses.cognitiveclass.ai/courses/course-v1:CognitiveClass+CO0401EN+v1/courseware/ea12e5b5b81f44489f2dc15692d39553/a9d72674d99c464abdf8159de90efab4/, to create a rule to collect telemetry data. But I failed to find the guestbook-telemetry.yaml file in v2 directory.

# istioctl create -f guestbook-telemetry.yaml

getForwardHeaders pulls the raw Jaeger headers. It should use OpenTracing API.

what's this useful for? I think it should fail instead of silently work and not use redis.

The minikube users needs to use node port, to access service, that gets created for load balancer service types. Also, the displayed output in the READMEs can varies per version of kubectl. We should let users know about both.

I have not found instructions for setting up Tone within IBM cloud. Detailed instructions should be added to the v2 README or a consolidated README (at the root repo level).

this makes the instructions wrong, with respect to accessing the app, if you want to have free clusters access it

Most of the files have hardcoded docker and infrastructure strings. These need to be removed in favor of a script that accepts variables.

We need a travis build/test process to have greater confidence in code/deploy changes.

The README for v1 and v2, under Create the guestbook pods, has k8s.gcr.io/guestbook:v3 as image which seems like an old output. The correct one per current manifest is bmcom/guestbook:v1.

I'm experimenting with v2 of the guestbook app and am finding there is an early problem with instructions at https://github.com/IBM/guestbook/tree/master/v2

In particular, in my cluster, when I run

$ kubectl create -f redis-master-deployment.yaml

I get the following error message:

In my laptop running minikube with GitVersion v1.16.2 and Platform:"darwin/amd64" after testing my installation with hello-minikube as per https://kubernetes.io/docs/setup/learning-environment/minikube/ and downloading redis-master-deployment.yaml onto my local HDD:

error: error parsing redis-master-deployment.yaml: error converting YAML to JSON: yaml: line 114: mapping values are not allowed in this context

In katacode.com running minikube v1.3.0 in the Launch Single Node Kubernetes Cluster scenario (I ran the scenario, then also tried doing the instructions for guestbook v2, starting with this failed first instruction:

$ kubectl create -f https://github.com/IBM/guestbook/blob/master/v2/redis-master-deployment.yaml

error: error parsing https://github.com/IBM/guestbook/blob/master/v2/redis-master-deployment.yaml: error converting YAML to JSON: yaml: line 114: mapping values are not allowed in this context

Having seen the same error in two different clusters, I think the error is with redis-master-deployment.yaml and not with both clusters.

Hope this helps.

My Watson Tone Analyser seems to have a problem. I get no tone analysis, and in the tracing I see 500s as a return HTTP code. In the logging it shows up as an SSL error.

SSLError: HTTPSConnectionPool(host='gateway.watsonplatform.net', port=443): Max retries exceeded with url: /tone-analyzer/api/v3/tone?version=2017-09-21&sentences=false (Caused by SSLError(SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)'),))

why does this exist? https://github.com/IBM/guestbook/blob/master/v1/guestbook/public/script.js#L29

from the docs:
NOTE: A Deployment that configures a ReplicaSet is now the recommended way to set up replication.

When adding an ingress reverse proxy and routing requests from /guestbook/v1 to servicename guestbook-v1 the relative paths created with mux are broken, e.g. to /env/info and the redis database.

When I try to deploy v2 on OpenShift accordingly lab instructions from a Dockerfile the builds are failed with the error: Error shutting down storage: A layer is mounted.
I've tried to repeat all the steps deleting the project but have the same errors during builds.

Copying blob sha256:6182a456504bb119011b721ede5d1e6cf4d0621447465d80cc1d4e53c0ef95e6
Copying blob sha256:5946d17734ce7686f86222b2d0d804ee5cb06cdb23ee6b056279185289336add
Copying config sha256:40349a2425efb3650843103390e2ace030c4288c96f3619cafb16320ab021efb
Writing manifest to image destination
Storing signatures

Pulling image ubuntu:18.04 ...
Getting image source signatures
Copying blob sha256:40dd5be53814ae70b2898558673b7ea18d58bf7ab3433560b9ce3cb76d9ff0b1
Copying config sha256:c6ad7e71ba7d4969784c76f57c4cc9083aa96bb969d802f2ea38f4aaed90ff93
Writing manifest to image destination
Storing signatures
Adding transient rw bind mount for /run/secrets/rhsm
Adding transient rw bind mount for /run/secrets/etc-pki-entitlement
Adding transient rw bind mount for /run/secrets/redhat.repo
STEP 1: FROM golang:1.15 AS builder
STEP 2: RUN go get github.com/codegangsta/negroni
# cd .; git clone -- https://github.com/codegangsta/negroni /go/src/github.com/codegangsta/negroni
Cloning into '/go/src/github.com/codegangsta/negroni'...
fatal: unable to access 'https://github.com/codegangsta/negroni/': Failed to connect to github.com port 443: Connection timed out
package github.com/codegangsta/negroni: exit status 128
STEP 3: FROM ubuntu:18.04
STEP 4: COPY --from=builder /go//main /app/guestbook
Error shutting down storage: A layer is mounted: layer is in use by a container
error: build error: error building at STEP "RUN go get github.com/codegangsta/negroni": error while running runtime: exit status 1