Git Product home page Git Product logo

icp-nodejs-sample's People

Contributors

a-roberts avatar bethgriggs avatar tomleah avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

saratrip drteck0 rafal-szypulka tobespc ibmlab19 lab3149-joehowell think2018labs lab3149-horvatca susanforbes chiruvenkat sensomax lab3149-sunjoshi lab3149-gtanguturi microservices-saidradhouani think2018-mlu ianc-d-icp lab3149-ludoscarfi test-microservice lab2darblock labdeiva lab3149-cloud791 ibmlabjgonzaleza lab3149-pdpeter lab3149-rohangupta85 wuchicago lab3149-kmhanson3 lab3149-kamal templab lab3149-bburgdave lab3149-shadowcab ibm-icp-2e chidaghcp lokeshm89 lab777 lab3149-mariowch srmalm lab3149-branka55 lab3149-randyarose lab3149-ssabat alsharafi77 neeraj-laad deesebas karbasih yathamravali bethgriggs gebhardtr carolynmabbott danielchudc

icp-nodejs-sample's Issues

Suggestions to improve your Dockerfile

Hi,

The Dockerfile can be improved in a couple of areas:

  1. Implement the best practice for writing Dockerfiles for running apt-get. The best practice says to always combine RUN apt-get update with apt-get install in the same RUN statement. For the full explanation see https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run
    For example:
RUN apt-get update && apt-get install -y  \
		wget \
	&& rm -rf /var/lib/apt/lists/*
  1. Add node_modules to .dockerignore. If you do the instruction RUN rm -rf ./node_modules; can be removed.
  2. Remove the instruction RUN cd /app;, you already used WORKDIR "/app" so you are already in /app
  3. Don't use semi-colons at the end of an instruction
  4. I wouldn't use COPY . /app, it copies everything in the current directory to /app (except what is in .dockerignore of course). The contents of /app with the current Dockerfile looks like this:
root@fa0fc7257bd6:/app# ls -latr
total 384
drwxr-xr-x   3 root root   4096 Feb 23 07:45 views
drwxr-xr-x   2 root root   4096 Feb 23 07:45 test
drwxr-xr-x   5 root root   4096 Feb 23 07:45 server
drwxr-xr-x   5 root root   4096 Feb 23 07:45 public
-rw-r--r--   1 root root   1135 Feb 23 07:45 package.json
-rw-r--r--   1 root root 266356 Feb 23 07:45 package-lock.json
drwxr-xr-x   4 root root   4096 Feb 23 07:45 multiarch-manifests
-rw-r--r--   1 root root    155 Feb 23 07:45 manifest.yml
-rw-r--r--   1 root root   2752 Feb 23 07:45 idt.js
-rw-r--r--   1 root root    672 Feb 23 07:45 gulpfile.js
drwxr-xr-x   2 root root   4096 Feb 23 07:45 docker-8
drwxr-xr-x   2 root root   4096 Feb 23 07:45 docker-6
-rw-r--r--   1 root root    556 Feb 23 07:45 cli-config.yml
drwxr-xr-x   3 root root   4096 Feb 23 07:45 chart
-rw-r--r--   1 root root   6712 Feb 23 07:45 README.md
-rw-r--r--   1 root root  13317 Feb 23 07:45 NOTICES
-rw-r--r--   1 root root  11351 Feb 23 07:45 LICENSE
-rw-r--r--   1 root root    147 Feb 23 07:45 Jenkinsfile
-rw-r--r--   1 root root    394 Feb 23 07:45 Dockerfile
-rw-r--r--   1 root root    109 Feb 23 07:45 .gitignore
drwxr-xr-x   7 root root   4096 Feb 23 07:45 .git
-rw-r--r--   1 root root      5 Feb 23 07:45 .dockerignore
drwxr-xr-x 133 root root   4096 Feb 23 07:48 node_modules
drwxr-xr-x   1 root root   4096 Feb 23 07:48 .
drwxr-xr-x   1 root root   4096 Feb 23 07:48 ..

In my view a lot of stuff that should not be in the /app directory. Of course you can update .dockerignore but it might be a better idea to create a separate folder for your code and copy that folder and individual files to /app instead.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.