ibm-developer / generator-ibm-cloud-enablement Goto Github PK

The template for the node generator has node:8 as base image in the generated dockerfiles. The node:8
image is based on Debian jessie, which is no longer supported for ppc64le and s390x architectures. So
the apt-get update in the generated dockerfiles now fails on those platforms, see
nodejs/docker-node#855

Proposed fix is to update the base image to node:8-stretch

The Kubernetes deployment via Delivery Pipeline fails in clusters running Kubernetes version v1.12.

This is caused because the kube-system default service account no longer has cluster-admin access to the Kubernetes API.

See: https://console.bluemix.net/docs/containers/cs_versions.html#cs_v112 (specifically the section related to role bindings).

How to reproduce the issue:

1. Click "Create resource".
2. Select "Python Microservice with Flask" under Starter Kits.
3. Create "Python + Flask" app under the "default" resource group in my personal account.
4. Click "Deploy to Cloud". Select "Deploy to Kubernetes" in Dallas to my own Kubernetes cluster and "default" resource group.
5. Click "View toolchain" and open the "Delivery Pipeline" in the next screen.
6. The "Build Stage" succeeds.
7. The "Deploy Stage" fails at line 48 of the .bluemix/scripts/kube_deploy.sh script.

$ helm upgrade --install --debug --dry-run ${RELEASE_NAME} ./chart/${CHART_NAME} --set image.repository=${IMAGE_REPOSITORY},image.tag=${BUILD_NUMBER} --namespace ${CLUSTER_NAMESPACE}

Error: UPGRADE FAILED: configmaps is forbidden: User "system:serviceaccount:kube-system:default" cannot list resource "configmaps" in API group "" in the namespace "kube-system"

If I use generator-ibm-java to generate a liberty app I can't start it on ppc64le.
It fails with:

[INFO] CWWKM2001I: Invoke command is [/opt/ibm/wlp/bin/server, create, defaultServer].
[INFO] JVMJ9TI001E Agent library am_ibm_16 could not be opened (libam_ibm_16.so: cannot open shared object file: No such file or directory)
[INFO] JVMJ9VM015W Initialization error for library j9jvmti29(-3): JVMJ9VM009E J9VMDllMain failed

The cause seems to be the apm agent library that is now loaded:

$ file libam_ibm_16.so 
libam_ibm_16.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=7f85911c0dc37ea4a0826f8119e7e7dd282152b5, not stripped

It looks like installUtility install --acceptLicense apmDataCollector-7.4 only installs an intel binary regardless of architecture. This prevents us starting the application on ppc64le.

All of the docker images are multi-arch and liberty is Java code so if I disable that in the docker file then the application starts without problem on ppc64le.

Using the implied latest tag for the image in the service.yml does not result in knative pulling the latest image when recreating pods. Hence application code updates are not deployed. The solution is to add imagePullPolicy: Always to the service yaml to indicate that the latest image should always be pulled.

We are missing installUtility in Dockerfile for liberty applications. Here is the change we need.
https://github.com/NottyCode/generator-ibm-cloud-enablement/blob/master/generators/dockertools/templates/java/Dockerfile.template

Pull request to support ppc64 (
#412)

RUN installUtility install --acceptLicense defaultServer

Liberty, Spring Boot 2, and others don't use /health, they use a variant.

In most cases, we're testing for a specified value, and using /health as a fallback, e.g.
/{{#if healthEndpoint}}{{healthEndpoint}}{{else}}health{{/if}}

Link to hard-coded endpoint in VSI pipeline yaml:

When node projects are generated with the "Alert" template for IBM Cloud enablement, this section is added to the deployment.yaml

env:
          - name: service_alert_notification
            valueFrom:
              secretKeyRef:
                name: binding-alert-name
                key: binding

If the Kubernetes cluster doesn't have the binding-alert-name secret, it'll fail to deploy. Is this secret needed? If not, can it be taken out? If it is needed, how can we work around it?

In latest liberty release "wget and unzip" utilities removed from the liberty image and these changes needed for the templates to work.

Template
https://github.com/ibm-developer/generator-ibm-cloud-enablement/blob/develop/generators/dockertools/templates/java/Dockerfile.template

Liberty doc to build application image..
https://github.com/WASdev/ci.docker/#building-an-application-image

Two issues have to be addressed here one is consume "configure.sh" and remove applying license in the Dockerfile and this should be option in "configure.sh" for customers.

The common kubernetes templates have repositoryUrl/applicationName in the Values.yaml file. The Java specific Kubernetes templates do not have this.

As noticed by @EnriqueL8:

Hey @quanvo87, this PR upgrade the version in npm to 0.13.0 but tagged the repo to 0.12.1. So it produced an inconsistency between the versions in npm and github... I believe this happened because after this PR was generated , a new commit was push to update the Package.json to 0.13.0. Could we look to fix this?

Caused by PR #250

@a-roberts also noticed this.

package.json currently has : "version": "0.13.0",

https://www.npmjs.com/package/generator-ibm-cloud-enablement?activeTab=versions has 0.13.0 as most recent.

most recent in Releases is 0.12.1

As of Docker 17.03 (March, 2017), https://docs.docker.com/engine/reference/builder/#maintainer-deprecated . The suggested replacement is:

LABEL maintainer="Old MAINTAINER value goes here"

As Swift 4.2 was released in September, alongside Xcode 10, we should update to Swift 4.2 (this obsoletes #332).