ibanity / ibanity-ruby Goto Github PK

Using the Ibanity gem to verify incoming webhook signatures fails when Ruby is compiled against OpenSSL 3. This seems to happen because of potatosalad/ruby-jose#19: The jose gem is not compatible with OpenSSL 3.

Newer versions of Linux, espacially Debian bookworm (the most recent stable release) does not include OpenSSL 1.1 anymore. OpenSSL 1.1 has been deprecated for a while now.

The jose gem seems not actively maintained anymore. Maybe the JWT signature validation should be replaced by a different gem/solution? Maybe the jwt gem can replace it?

As shown in the curl documentation, the last_synchronization and synchronized_at provide info about the latest synchronization of the account transactions. We should handle this in the method.

In PaymentInitiationRequest, the resource type should be paymentInitiationRequest according to the documentation

When looking at https://github.com/ibanity/ibanity-ruby/blob/master/lib/ibanity/api/customer_access_token.rb#L3 it doesn't seem that the applicationCustomerReference attribute is mandatory, nor do the documentation imply so.

Wouldn't it be more convenient if it was mandatory in the method signature ?

The Restclient timeout is not configurable. This is a problem, because the default timeout is set to 60 seconds (timeout and open timeout). This can result in a worst case waiting time of 120 seconds, which is a lot for some of applications.

The timeout should therefore be configurable in the client.