iandunn / regolith Goto Github PK

In deploy:shared an empty /web/wordpress folder is created.

This is before deploy:install_dependencies where install_dependencies.sh checks and conditionally installs core based on the existence of the /web/wordpress folder. Because of the previous task creating the folder to make it available to symlink in to shared, core is never installed.

I'm not 100% sure why web/wordpress is included as a shared folder in $other_shared around line 55 in regolith-recipe.php. It could be removed from here if not needed to solve the issue, or install_dependancies.sh can be modified to check for the presence of another folder inside /web/wordpress such as wp-admin as the deploy:shared task is just making an empty folder.

Using git submodules for plugins and themes not on the wordpress.org repo is a great workflow for us and solves the issue of things not being on the .org repo quite nicely.

However there aren't any docs for this just now really, barring something in the TODO.md.

Also the deployer recipe can probably be adjusted a bit as the submodules are not in the .gitignore so are not symlinked as shared:

When running deployer deploy my fresh install was complaining about not being able to find .gitignore to get the dependancies.

Seems to be this line:

Changing to this sorts it out:
$potential_dependencies = file( dirname( dirname( __DIR__ ) ) . '/.gitignore', FILE_IGNORE_NEW_LINES );

Not 100% sure if this is related to 048806b

Deployer 5 is now using "hosts" instead of servers. It also now supports relative symlinks but not in a great way as it just checks if it can use ln --relative as far as I can tell. The current regolith implementation of relative symlinks is better in my view as it works on more shared hosts.

Also the Deployer wrapper included with regolith tripped me up a bit as it uses /usr/bin/php all the time, whereas I had my path set to use my MAMP php and its php.ini . Also it seems Deployer likes to use dep as the binary name and v5 can be called anywhere in the project so there may not be much need for the wrapper anymore.

I am working on the move to v5 and will probably put a PR in.