Git Product home page Git Product logo

secrethitler's Issues

Swap discard for select in president and chancellor policy picks

From all friends who’ve played, the human instinct is to pick the policy/tile you want to play. There have been many times a person will accidentally play what they meant to discard.

President would then select two policies and chancellor would select one.

[bug] Check winning conditions after three failed votes

When enacting the top card of the draw pile after three failed votes the winning conditions have to be checked. It might be the case that this law is the final one for either liberals or fascists. So a check like update.liberal == 5 || update.fascist == 6 needs to be added at the end of this code block.

// voting was a fail
} else if (update.voteresult == "fail") {
// reset trackerenact.message so flashmessage doesn't go off
update.trackerenact = { topcard: "", message: "" };
update.electiontracker = room.electiontracker + 1;
// enact top policy if election tracker is at 3
if (update.electiontracker == 3) {
let drawpile = room.drawpile;
// console.log("tracker at 3. drawpile:", drawpile);
if (drawpile.length == 0) {
drawpile = drawpile.concat(room.discardpile);
update.discardpile = [];
// console.log("tracker at 3. concat discard into drawpile", drawpile);
}
let topCard = drawpile.splice(0, 1);
update.drawpile = drawpile;
update.trackerenact = {
topcard: topCard,
message: `a ${topCard} policy has been enacted!`
};
}
}
}

[Suggestion] Highlight "Hitler Zone"

Highlight or in some way show that the point on the board when Hitler being elected chancellor would result in the game over.

I suggest highlighting the section of the board at the top, but perhaps there's a better way to implement this?

[Suggestion] On Election fails, continue shouldn't remove you from the vote list

When an election fails, if you click continue no one else will see you in the vote list any longer.

This should probably stick for everyone until they click continue - we found that we had to add a house rule that no one click continue until everyone had a chance to look at the votes (much like asking people to keep their cards on the table til everyone sees them).

Other parts of the game skip ahead when someone clicks continue, those could probably be slowed down similarly so no one is ever prevented from seeing information when they might want to.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.