Uncaught TypeError: undefined is not a function about bootstrap-offcanvas HOT 15 CLOSED

@DaveLindberg What line is the error on? Do you get the error on http://iamphill.github.io/Bootstrap-Offcanvas/example.html?

from bootstrap-offcanvas.

http://iamphill.github.io/Bootstrap-Offcanvas/example.html is coming up clean.

Looks like the error (on my install) is on line 229. JSHint throws warnings on:
line 233
return oc = "Did you mean to return a conditional instead of an assignment? — column 18"
line 237
return $(this).on('click', function(e) { "'e' is defined but never used. — column 43"
I installed the components using bower.

from bootstrap-offcanvas.

@DaveLindberg Hmm.. 229 would be https://github.com/iamphill/Bootstrap-Offcanvas/blob/master/dist/js/bootstrap.offcanvas.js#L229 which would surely mean that $ isn't available. jQuery is available right?

from bootstrap-offcanvas.

Confirmed, jQuery is loading properly — before the bootstrap.offcanvas.js

from bootstrap-offcanvas.

@DaveLindberg Could you upload a demo somewhere where it isn't working?

from bootstrap-offcanvas.

See http://webdev.davelindberg.com/

from bootstrap-offcanvas.

@DaveLindberg Ah I see the issue, angularJS redefines the $ variable. Will get a fix out ASAP.

from bootstrap-offcanvas.

Fantastic, thanks!

from bootstrap-offcanvas.

@DaveLindberg Just released 1.3.5 if you could try that.

from bootstrap-offcanvas.

I've posted the v1.3.5 version to http://webdev.davelindberg.com/
Still getting an error. Line 149?

from bootstrap-offcanvas.

@DaveLindberg Just checked your demo, and it is still showing the older version?

Just created a PR anyway with a test. Could you try using #10 ?

from bootstrap-offcanvas.

#10 is working fine on my local install. Oddly, it still throws an error on webdev. I've check the two files and found no diff, not sure what's happening here?

from bootstrap-offcanvas.

@DaveLindberg Your one http://webdev.davelindberg.com/wp-content/themes/angwobo/bower_components/bootstrap-offcanvas/dist/js/bootstrap.offcanvas.js?ver=4.1.1 looks different to https://raw.githubusercontent.com/iamphill/Bootstrap-Offcanvas/dollar-fix/dist/js/bootstrap.offcanvas.js

from bootstrap-offcanvas.

Thx. Not sure why, but there's a trailing newline on the webdev version that I can't get rid of — don't know why. Other than that, the latest version should be in place.

And yes, this fix does the job nicely on my local server.

from bootstrap-offcanvas.

@DaveLindberg Cool, will get it merged in.

Styling on your version is off. Looks like you haven't included Bootstrap.

from bootstrap-offcanvas.