Comments (15)
@DaveLindberg What line is the error on? Do you get the error on http://iamphill.github.io/Bootstrap-Offcanvas/example.html?
from bootstrap-offcanvas.
http://iamphill.github.io/Bootstrap-Offcanvas/example.html is coming up clean.
Looks like the error (on my install) is on line 229. JSHint throws warnings on:
line 233
return oc =
"Did you mean to return a conditional instead of an assignment? — column 18"
line 237
return $(this).on('click', function(e) {
"'e' is defined but never used. — column 43"
I installed the components using bower.
from bootstrap-offcanvas.
@DaveLindberg Hmm.. 229 would be https://github.com/iamphill/Bootstrap-Offcanvas/blob/master/dist/js/bootstrap.offcanvas.js#L229 which would surely mean that $
isn't available. jQuery is available right?
from bootstrap-offcanvas.
Confirmed, jQuery is loading properly — before the bootstrap.offcanvas.js
from bootstrap-offcanvas.
@DaveLindberg Could you upload a demo somewhere where it isn't working?
from bootstrap-offcanvas.
See http://webdev.davelindberg.com/
from bootstrap-offcanvas.
@DaveLindberg Ah I see the issue, angularJS redefines the $
variable. Will get a fix out ASAP.
from bootstrap-offcanvas.
Fantastic, thanks!
from bootstrap-offcanvas.
@DaveLindberg Just released 1.3.5 if you could try that.
from bootstrap-offcanvas.
I've posted the v1.3.5 version to http://webdev.davelindberg.com/
Still getting an error. Line 149?
from bootstrap-offcanvas.
@DaveLindberg Just checked your demo, and it is still showing the older version?
Just created a PR anyway with a test. Could you try using #10 ?
from bootstrap-offcanvas.
#10 is working fine on my local install. Oddly, it still throws an error on webdev. I've check the two files and found no diff, not sure what's happening here?
from bootstrap-offcanvas.
@DaveLindberg Your one http://webdev.davelindberg.com/wp-content/themes/angwobo/bower_components/bootstrap-offcanvas/dist/js/bootstrap.offcanvas.js?ver=4.1.1 looks different to https://raw.githubusercontent.com/iamphill/Bootstrap-Offcanvas/dollar-fix/dist/js/bootstrap.offcanvas.js
from bootstrap-offcanvas.
Thx. Not sure why, but there's a trailing newline on the webdev version that I can't get rid of — don't know why. Other than that, the latest version should be in place.
And yes, this fix does the job nicely on my local server.
from bootstrap-offcanvas.
@DaveLindberg Cool, will get it merged in.
Styling on your version is off. Looks like you haven't included Bootstrap.
from bootstrap-offcanvas.
Related Issues (20)
- Events fire in wrong order
- The offcanvas menu automatically closes when the input is clicked in mobile HOT 6
- Android HOT 1
- Multiple offcanvas menus
- Dropdowns don't open in desktop view HOT 9
- Doesn't work using AngularJS ngView
- Can't scroll contents when window resized HOT 1
- Gap below offcanvas menu area when scrolled down HOT 6
- Composer HOT 1
- Move to ES6 HOT 2
- Drop jQuery
- Plugins
- On window resize - remove the body class "offcanvas-stop-scrolling"
- Incompatible with Turbolinks HOT 3
- Disable close offcanvas menu after click on document
- Manually open menu when click on button not in menu
- New logo for Bootstrap-Offcanvas
- Allow to have several elements that use the same target
- menu maximizes invisibly when touching anywhere on the page
- offcanvas does not work if there are more elements inside the button. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-offcanvas.