Git Product home page Git Product logo

portfolio's People

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

portfolio's Issues

Using !important in your css

Changes

Hi @iambenkis, good job so far!

  • Please refrain from using !important in your CSS (at line 133) as it is often considered bad practice because it has side effects that mess with one of CSS's core mechanisms: specificity.
  • It makes your CSS harder to maintain and debug on the long run.

Button Color

Almost there ๐Ÿคž

  • please change the color of the :hover effect in your CSS to match the one in the Figma template

Peer to peer code review - week 4

Hi @iambenkis ๐Ÿ‘‹, You did an excellent job ๐Ÿ‘! Your website looks nice and clean according to the Figma template. Here are a few suggestions which can improve your website user experience:

  • Try adding a background to the navbar so that the text in the navbar does not overlap with the rest of the website.
  • You can put the whole contact form in one div to make it more responsive.
  • Try giving a different class name to the header section.
  • Try adding your social links to the social media icons.

Work Section - Language Tag Case

Welldone @iambenkis ๐Ÿคž'

Kindly change the laguage tag text under work section (html, css, javascript) to lower case. This will help you achieve exact replica of the design you are working with.

Peer to Peer Code Review

Blossom Aniedi

  • Great use of HTML semantic tags but it would be advisable to use other semantic tags like section, and article alongside divs.
  • The alternative images should always be specified.

Bugs found inside script.js file

Hi @iambenkis, ๐Ÿ‘‹

Lots of bugs were found inside the .html file but few in the .js file (on the locale-storage feature branch)
The only bug that was detected in the script.js file which might cause a linter error is:

  1. On line 125 of scripit.js, there is a trailing space. Please remove it to fix the linter error.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.