The puzzle 10-e69f73e3 from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 0-7ae6cd57 from #0 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 6-57333c2d from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 19-ec246873 from #19 has to be resolved:

⚠️ Maybe it would be helpful to audit these codexia_meta entities.

The puzzle was created by Maksim Iakunin on 17-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

https://github.com/pre-commit/pre-commit

Take a look: https://www.codexia.org/p/774

I see meta information stored about Reddit and HN, but no reviews posted. Is it a bug?

The puzzle 6-02060b89 from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

• Change the format of all existing TODOs
• Add pdd-format check to CI

Sentry Issue: CODEXIA-BOT-E

DataIntegrityViolationException: could not execute statement; SQL [n/a]; constraint [uq__hackernews_item__external_id]; nested exception is org.hibernate.exception.ConstraintViolationException: could not execute statement
    at dev.iakunin.codexiabot.hackernews.service.Database.write(Database.java:23)
    at dev.iakunin.codexiabot.hackernews.service.Composite.lambda$write$0(Composite.java:21)
    at dev.iakunin.codexiabot.hackernews.service.Composite.write(Composite.java:21)
    at dev.iakunin.codexiabot.hackernews.cron.IncrementedParser.run(IncrementedParser.java:38)
...
(28 additional frame(s) were not displayed)

ConstraintViolationException: could not execute statement
    at org.hibernate.exception.internal.SQLStateConversionDelegate.convert(SQLStateConversionDelegate.java:109)
    at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:42)
    at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:113)
    at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:99)
    at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:200)
...
(70 additional frame(s) were not displayed)

PSQLException: ERROR: duplicate key value violates unique constraint "uq__hackernews_item__external_id"
  Detail: Key (external_id)=(22812684) already exists.
    at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2497)
    at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2233)
    at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:310)
    at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:446)
    at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:370)
...
(75 additional frame(s) were not displayed)

Exception occurred during getting hackernews item '22812684'

This exception can be prevented by:

1. Using DB locks on cron-commands.
2. Using lock by hackernews.external_id on Database Writes.

ShedLocks

• https://www.baeldung.com/shedlock-spring
• https://github.com/lukas-krecan/ShedLock#locking-without-a-framework

That's because codexiaModule.saveReview() call instead of sending to codexia.

The puzzle 6-5af20361 from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

https://codebeat.co/

https://codebeat.co/projects/github-com-llorllale-go-gitlint-master

https://codebeat.co/projects/github-com-yegor256-takes

The puzzle 19-799ed7e1 from #19 has to be resolved:

The puzzle was created by Maksim Iakunin on 17-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

• PMD
• Checkstyle
• FindBugs

• Check how the code-style violations look like in pull-requests.

• Set up all existing code-style check tools with maximum strictness.

The puzzle 6-3551727a from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 6-af8b3d4f from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 10-6d9090eb from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

https://bettercodehub.com/

The puzzle 10-c5423926 from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 10-d0e206d9 from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

In the scope of this issue multiple pdd-puzzles should be added to decompose the whole scope of testing.

There are also useful resources concerning testing best-practices:

• https://www.freecodecamp.org/news/unit-testing-services-endpoints-and-repositories-in-spring-boot-4b7d9dc2b772/
• https://www.baeldung.com/integration-testing-in-spring
• https://www.baeldung.com/spring-boot-testing
• https://dzone.com/articles/unit-and-integration-tests-in-spring-boot-2
• https://phauer.com/2019/modern-best-practices-testing-java/
• https://phauer.com/2019/focus-integration-tests-mock-based-tests/
• https://martinfowler.com/articles/practical-test-pyramid.html
• https://tanzu.vmware.com/content/blog/what-is-a-unit-test-the-answer-might-surprise-you

The puzzle 10-a0a04470 from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

• https://restyled.io/
• https://github.com/marketplace/restyled-io

The puzzle 10-2ff894fd from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 10-f8a4ea3e from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 6-facd1e77 from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

See the issue database-rider/database-rider#202

• Update rider-spring to 1.13.0 when it's released
• Rewrite all the tests to using cleanBefore instead of executeScriptsBefore
• Rewrite all the tests to using cleanAfter instead of executeScriptsAfter

The puzzle 10-3ebb1a8d from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

See https://app.circleci.com/pipelines/github/iakunin/codexia-bot/114/workflows/4b1c1b98-755b-47c2-81bf-53d2675d2e51/jobs/164

git branch -f master origin/master
fatal: Cannot force update the current branch.

Choose from:

• https://github.com/llorllale/go-gitlint
• https://github.com/jorisroovers/gitlint

The puzzle 10-d5175438 from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 50-620293b3 from #50 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 10-5ffba3e0 from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Motivation: there should be one place with pdd-config.

For example see: https://github.com/zerocracy/farm/blob/master/.pdd

As we can see here there is a case when review are submitted with some delay (because of the daily review creation limits on Codexia).

To clarify the situation it would be better to add a date-time of review creation (on the bot side) to review text.

Expected review text:

The repo gained 34 stars: from 270 (at 2020-02-26T23:23:37Z) to 304 (at 2020-04-13T12:11:22Z). See the stars history here.

The puzzle 6-4d9a1ad5 from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 6-cae02d85 from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

• https://sonarcloud.io/documentation/analysis/pull-request/
• https://circleci.com/docs/2.0/env-vars/

The puzzle 6-ba4d7ce3 from #6 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 10-137a4b3c from #10 has to be resolved:

The puzzle was created by Maksim Iakunin on 20-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

According the conversation here there are following rules for submitting a new project to Codexia:

• Don't submit if there is no activity over the last year.
• Don't submit with less than 100 stars.
• Don't submit if there are more than 10K stars.
• Don't submit if there are less than 5K lines of code.

Extra:

• Don't submit if there is no README in repo.
• Don't submit if the language of a README is not English.

Make this method "public" or remove the @Transactional annotation: link to bug.

The puzzle 19-703b27a3 from #19 has to be resolved:

The puzzle was created by Maksim Iakunin on 17-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 0-2d57295c from #0 has to be resolved:

The puzzle was created by Maksim Iakunin on 13-Apr-20.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.