Git Product home page Git Product logo

Comments (8)

robertknight avatar robertknight commented on May 27, 2024

@judell - It is difficult to see exactly what is going on because that page has a large number of annotations. Unless it is crucial to reproducing or understanding the issue, it is much easier to see what is happening if you have the simplest possible test case.

Can you also confirm that what you are seeing here is different to #90 ?

from client.

nickstenning avatar nickstenning commented on May 27, 2024

I've tried pretty much everything I can think of to reproduce this, including pretty much every entry in a matrix with the following axes:

  • same user/different users
  • public/in a group
  • annotations/page notes
  • creating/updating/deleting
  • annotating strictly before/strictly after/overlapping start/overlapping end/exact match/inside
  • heavily annotated pages/lightly annotated pages

And I haven't seen the issue described once, I'm afraid.

Could you confirm that you were using the latest client release, v0.39.0, which fixed exactly this issue, which Jeremy previously reported here.

from client.

jeremydean avatar jeremydean commented on May 27, 2024

it's hard for me to see in the video that the annotation is actually destroyed as opposed to just moving so far from view that it is basically lost to me, especially given how many annotations are on the page. could it just have moved so far in the sidebar--and/or the location in the PDF moved as well?

from client.

judell avatar judell commented on May 27, 2024

@jeremydean that might indeed be the situation.

Consider:

http://jonudell.net/h/reply-seemingly-gone-when-concurrent-annotations-flow-in.mp4

The setup here: A Python script is pumping in annotations from 4 different users, once per second, while a reply is in progress. Pretty quickly the in-progress annotation seems to vanish. I can reproduce this behavior at will.

I can't go back in time and check the prior screencast. Was the in-progress card still there somewhere? Seems plausible, especially on a heavily-annotated page.

from client.

jeremydean avatar jeremydean commented on May 27, 2024

Right, a key here is the number of concurrent annotators/annotations. @robertknight @nickstenning

from client.

robertknight avatar robertknight commented on May 27, 2024

@judell - Can you provide the script you are using and any other setup details please? I'd like to reproduce this for myself.

from client.

judell avatar judell commented on May 27, 2024

@robertknight Yes, I'll send it to you directly because it includes tokens.

from client.

judell avatar judell commented on May 27, 2024

Closing in favor of #90

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.