Git Product home page Git Product logo

Comments (2)

lyzadanger avatar lyzadanger commented on May 27, 2024

@judell I confess, I've read the description a few times and I'm not immediately wrapping my head around the summary of the issue—before I try to grok, I thought I'd ask if you knew offhand if this is still an issue worthy of investigation? Thanks!

from client.

robertknight avatar robertknight commented on May 27, 2024

To summarize:

  1. A page was annotated at a time when it did not have <link rel=canonical> in it
  2. A <link rel=canonical> was added later, with a URL that differs from the actual URL of the page
  3. The URL from (2) now overrides the real page URL, so annotations made in step (1) no longer appear

The current state is that this is expected behavior. Hypothesis has always given precedence to the <link rel=canonical> URL. We do now have an admin tool in h which can be used to bulk migrate annotations from one set of URLs to another and developers can use the API to update the URLs of existing annotations. There is still no functionality for non-technical users to edit the URLs of existing annotations however (see #5220). Annotations made on the original URL don't show up for the reasons explained above, but they are accessible through the notebook and activity pages.

I'm closing this as "works as expected", although it would obviously be useful to have a mechanism for users to modify URLs of existing annotations so that they do show up on the new URL.

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.