hyperoslo / cardstack Goto Github PK

Support dragging the front screen down to see the list, if you're using a scroll view you could achieve this by looking if you're at the beginning of the view.

Why is this not written in Swift?

I've seen many methods that return suddenly in the middle of their operation if an if statement applies. Might be better to use if and else in this cases, returning in the middle of methods is error prone, hard to debug and might cause unexpected behaviour for other developers that are not that familiar with the codebase.

There are 2 types of warnings:

• Accessing property ivar directly
• Different int comparisons.

CardStackController.m:75:5: Instance variable '_currentCardIndex' is being directly accessed
CardStackController.m:177:18: Comparison of integers of different signs: 'NSInteger' (aka 'long') and 'NSUInteger' (aka 'unsigned long')

I played with this before doing collections. Maybe it could have been useful for inspiration.

https://github.com/3lvis/ANDYCardStack

The processing in the completion block should be necessary. Data consistency should be handled by the library.

- (void)removeAction:(UIButton *)button {
    NSInteger index = button.superview.tag;
    [self.cardStackController removeCardAtIndex:index animated:YES withCompletion:^{
        for (NSUInteger i = 0; i < self.viewControllers.count; i++) {
            UIViewController *viewController = [self.viewControllers objectAtIndex:i];
            viewController.view.tag = i;
        }
    }];
}

This should just work:

- (void)removeAction:(UIButton *)button {
    NSInteger index = button.superview.tag;
    [self.cardStackController removeCardAtIndex:index animated:YES withCompletion:nil];
}