hype / hype_as3 Goto Github PK

and maybe also ColorTransform? Just a thought :) Loving your work so far though! :) :) :)

... if largeCanvas is set of course! :-)

The speed, turnEase and twitch properties should be exposed so that they can be changed at run time.

If you export a second PNG I don't think the progress bar is cleared. It appears full right from the start. Cheers!

Seb

I may be overlooking something, but it would be better for colorChildren to check if the child was a DisplayObject? This would enable us to color Shapes, TextFields, etc using the ColorTransform, not just subclasses of InteractiveObject.

Mark

This will help with extending classes

I'm looking into the latest Pure AS3 examples before tomorrow's workshop, but I'm having trouble running them (creating a Debug Configuration) from within FDT.

This is due to the fact that the path to the Main (runnable) class contains spaces:
examples/Pure AS3/src/

I would suggest to rename it to:
examples/pure_as3/src/

Spaces in file names and Capitalized words always give trouble on some systems.

(I'm on Mac OSX 10.6 Snow Leopard running Eclipse 3.5 with FDT Enterprise 3.5)

Otherwise you get a runtime error. Just a suggestion. I really love this codebase, seriously good work guys!

Sorry to add this after you've got through all of the issues on here!

The ILayout interface would be better defined as the below. This would enable us to change layouts at runtime by coding to the interface rather than the implementation.

package hype.framework.layout
{
import flash.display.DisplayObject;
import flash.geom.Point;

/**
 * Interface all Layouts must implement
 */
public interface ILayout
{
    /**
     * Apply the layout to a DisplayObject
     *
     * @param object The DisplayObject to position
     */
    function applyLayout( object:DisplayObject ):void;
    /**
     * Get the next point from the layout
     *
     * @return Next point from the layout
     */
    function getNextPoint():Point;
}

}

I will be forking HYPE soon, but for now I thought I'd add anything I find to here.

Keep up the good work!

If you try to unload a movie containing any Hype class, flash palyer hangs. This is because RhythmManager is a global object and all rhythms are still alive when movie unload, but targets are dead and hundreds of errors are thrown blocking execution.
A solution may be (I did it) adding this simple public method to RhythmManager Class:

    //added by Bruno Migliaretti
    public function removeAllRhythms () {
        for (var r in _rhythmTable) {
            removeRhythm(r);
        }
    }

and add a call to this method to Event.UNLOAD event.

This will help with performance

The ObjectPool assumes that the object has triggers and behaviours when you try to release it and throws a runtime error. This is because the static property 'manager' hasn't been instantiated yet. Here's some code to reproduce:

protected var _pool:ObjectPool;

public function HYPETest():void
{
_pool = new ObjectPool( Circle, 1 );
_pool.onCreateObject = createCircleObject;
_pool.requestAll();
}

protected function createCircleObject( circle:Circle ):void
{
circle.addEventListener( MouseEvent.CLICK, circleClickListener );
addChild( circle );
}

protected function circleClickListener( e:MouseEvent ):void
{
var circle:Circle = Circle( e.currentTarget );
circle.removeEventListener( MouseEvent.CLICK, circleClickListener );
removeChild( circle );
_pool.release( circle );
}

Could this be rectified by using lazy instantiation of the manager using a public static getter for the manager, rather than instantiating it in the AbstractTrigger/AbstractRhythm?

Btw, this is an awesome framework/toolkit!

Mark