hydro-project / common Goto Github PK

Hi, I was browsing the code to try and understand it more, and I saw in kvs_client.hpp the method get_request_id()

  /**
   * Generates a unique request ID.
   */
  string get_request_id() {
    if (++rid_ % 10000 == 0) rid_ = 0;
    return ut_.ip() + ":" + std::to_string(ut_.tid()) + "_" +
           std::to_string(rid_++);
  }

It looks to me like you are pre-incrementing rid_ in the comparison to 1000, then post-incrementing it when forming the string at the end, so double incrementing it each time.

It's not like that should be a problem if you just want a unique number each time, but I wanted to mention it to see if I understood it correctly, or learn there is a reason for incrementing the request ID by 2 each time.

BTW: If this method is used by multiple threads without some locking/atomic mechanism outside this method, then there is a potential race condition here, no?