huridocs / uwazi Goto Github PK

Blank state on uploads form when no document types exist

When creating a document type in the metadata section, is some sort of realtime duplicate validation going on? We should add a time trigger for that otherwise is unusable for slow connections.

Specially when a document template has been updated adding a new property, users need an easy way of keeping track of documents lacking that new property.

The date displayed in the document card beside the document type is the upload date. This is misleading and can easily be read as ie "Sentence 25-07-2009", as in being a court sentence issued in 25-07-2009.

We need to create a better design for this.

Let users know exactly where they are, ie:

metadata > create new
metadata > edit > decision
library > view > Some document title
uploads > view > Some document title
library > view > Some document title > create reference to a paragraph > Some other document title

When the user is not int he top of the window he doesn't see the alerts.

Code duplication? this could even lead to displaying different icons if the code is changed separately.

https://github.com/huridocs/UwaziDocs/blob/9fcc2009263a36f4885b0e0bcc7bd70dfef2c973/app/react/Templates/components/MetadataProperty.js

let iconClass = 'fa fa-font';
    if (this.props.type === 'select') {
      iconClass = 'fa fa-sort';
    }

    if (this.props.type === 'list') {
      iconClass = 'fa fa-list';
    }

    if (this.props.type === 'date') {
      iconClass = 'fa fa-calendar';
    }

    if (this.props.type === 'checkbox') {
      iconClass = 'fa fa-check-square-o';
    }

https://github.com/huridocs/UwaziDocs/blob/9fcc2009263a36f4885b0e0bcc7bd70dfef2c973/app/react/Templates/components/FilterSuggestions.js

getTypeIcon(type) {
    let icon;
    switch (type) {
    case 'checkbox':
      icon = 'fa fa-check-square-o';
      break;
    case 'select':
      icon = 'fa fa-sort';
      break;
    case 'list':
      icon = 'fa fa-list';
      break;
    case 'date':
      icon = 'fa fa-calendar';
      break;
    default:
      icon = 'fa fa-font';
    }

    return icon;
  }

@danicatalan please upload the design asset in https://github.com/huridocs/uwazi-assets

Sometimes PDFs already have links. We should be careful with PDF hacks, such as storing XSS baits in the content etc.

Lint the backend code and add the step to the CI server

Properly setup code coverage for ES6 to include server tests as well.

• Display amount of results and refine the search filters.

ie. In faceted browsing we can see upfront the amount of results per filter, as in a country filter:
Argentina (5)
Peru (1)
Ecuador (0) -> This one may even not show up if it has zero results.

Upon selection, other "subfilters" should be updated to reflect the actual results if combined with the active filters.

• Password change workflow
• Edit "Collection name"

This is a test issue

HowToImproviseJazz.pdf

When saving matadata elements store locally the revision sent by couchdb so on resaving the element is not duplicated.

Password is not stored with proper encryption.

@daneryl @konzz

Testing how we can use issues for code review. So far I'm not happy with the inline comments (blame). Github's interface for this sucks big time. Comments get lost, there is no way of tracking what conversations are active etc. The official suggestion is to use pull requests, which I think is a total overkill unless you are conducting a full code review.

Code style suggestion, replace switch statements with object literals: https://toddmotto.com/deprecating-the-switch-statement-for-object-literals.

https://github.com/huridocs/UwaziDocs/blob/9fcc2009263a36f4885b0e0bcc7bd70dfef2c973/app/react/Templates/components/FilterSuggestions.js

getTypeIcon(type) {
    let icon;
    switch (type) {
    case 'checkbox':
      icon = 'fa fa-check-square-o';
      break;
    case 'select':
      icon = 'fa fa-sort';
      break;
    case 'list':
      icon = 'fa fa-list';
      break;
    case 'date':
      icon = 'fa fa-calendar';
      break;
    default:
      icon = 'fa fa-font';
    }

    return icon;
  }

ATM we have deactivated font loading. These fonts take up to 1MB per font, making document rendering and loading too heavy. We need to come to a usable solution for this problem.

When trying to load a document id that does not exist the app stays loading forever we need to detect it and show a 404 ?
This might happen if a user accidentally changes the URL of a document.

Take search to the next level where users can even choose how the want filters to stack (AND/OR) and other options TBD.