hunesion / ossnacclient Goto Github PK
View Code? Open in Web Editor NEW이 프로젝트는 사용자 단말의 안정성을 확보하여 내부 네트워크에 접근을 허용하는 개방형OS 기반의 네트워크접근통제 클라이언트를 개발합니다.
License: GNU Lesser General Public License v2.1
이 프로젝트는 사용자 단말의 안정성을 확보하여 내부 네트워크에 접근을 허용하는 개방형OS 기반의 네트워크접근통제 클라이언트를 개발합니다.
License: GNU Lesser General Public License v2.1
If the policy is changed while the policy script is running, the changed policy is not applied or executed, so improvement is required.
Request for documentation for build. Exact same request with Hunesion/ossFileTransferClient#18.
Again having a hard time to build the project, hitting errors while installing libgtk-3-dev
.
Configuration files must be encrypted and stored locally.
Currently, INIManager does not consider encryption.
Please consider the scalability of INIManager to encrypt the configuration file.
For more efficient code maintenance, I recommend to avoid C style casting (such as (struct struct_name *) void_ptr
)
There are several reasons why C++ style casting should be used instead of C style casting. (Also mentioned in #56 too)
_cast
.I found that there are some commented codes without any explanation in "nacapplication.cpp". So, I suggest writing some comments about those codes. (or removing them if they are no longer used)
ossNacClient/nac_client/src/ui/nacapplication.cpp
Lines 115 to 122 in 8a8a243
ossNacClient/nac_client/src/main.cpp
Lines 10 to 15 in 8a8a243
Seems like the code style / format of this project differs by source files, thus sometimes it is hard to read and understand codes.
To encourage source contribution, I recommend to integrate code linter (or formatter) on this project.
See the best practices of C/C++ Linters: https://github.com/caramelomartins/awesome-linters#cc
Suggestions for NAC ㄸnd-user status classification
-Can the NAC server distinguish the current End-user state?
-In other words, it would be nice if the server could check if the NAC Agent was installed on the End-user's PC.
I suggest to add tests for testing modules of this project. Recommendation: Google test for C++: https://docs.microsoft.com/ko-kr/visualstudio/test/how-to-use-google-test-for-cpp.
We can run unit tests per module. For example, we can add encryption/decryption tests for crypto.cpp
.
Exact same issue compared with here. Hunesion/ossFileTransferClient#19
At this point, I do not recommend using travis-ci. See security flaw: https://arstechnica.com/information-technology/2021/09/travis-ci-flaw-exposed-secrets-for-thousands-of-open-source-projects/.
Instead, I suggest to jenkins or Github Actions.
I found that there are some files are using NULL for assigning null to pointers and some files are using nullptr for it. Moreover, It seems that "DirectoryMonitor.cpp" uses both two methods in one code.
ossNacClient/nac_client/src/core/DirectoryMonitor.cpp
Lines 91 to 110 in fc3b928
Therefore, I suggest using consistent method for assigning null to pointer.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.