Git Product home page Git Product logo

grimgrains's Introduction

Hundred Rabbits

This repository is the sources for the Hundred Rabbits website. The website is written in C, and requires gcc to build. To rebuild the site, run the build script:

make run

Extras

  • Pull Requests are welcome.
  • The source code of 100r.co is licensed under MIT and the images, text and assets are licensed under BY-NC-SA 4.0. View individual licenses for details..

grimgrains's People

Contributors

dweremeichik avatar fixato avatar georgeblahblah avatar heyitsols avatar kreutziger avatar lcb931023 avatar lctrt avatar make-github-pseudonymous-again avatar microlith57 avatar mpiffault avatar neauoire avatar nfd9001 avatar rekkabell avatar rosano avatar sbssk8 avatar smlavine avatar thibautre avatar thomasorus avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

grimgrains's Issues

[Suggestion] Sub-ingredient lists

I suggest that for ingredients such as flour, a list of sub-ingredients should be shown (eg. all purpose, wholewheat, einkorn, etc.) and in these sub-ingredients' pages a link would take you back up.

This could be implemented a bit like in Paradise - a Parent ingredient for each ingredient, which can be blank, and then autogenerate everything from there.

Use browser native lazy-loading

Hello!

Problem: Grimgrains loads 4.64mo of images on the homepage for the 247 ingredients listed. It makes the page too heavy to load on small connection when loaded for the first time.
Solution: It would be easier for slow connections to lazy-load those images using the loading="lazy" attribute on images. This way browsers who support this feature will only load images in the viewport, which will result in less data to load and see the top of the website.

Thanks!

License not clear on website

In the About page, it is stated that the content of Grimgrains is copyright with all rights reserved.

Perhaps it would be good to replace this with the MIT license terms as this is Grimgrains' license? The wording is technically true as is, but it would help if the MIT terms were explicitly stated / referenced.

Accessibility Issues

Hello here!

Grimgrains has small accessibility issues that are quite easy to fix.

Important issues:

  1. Provide a visible focus on links with images
    Problem: The website has an outline:none rule on the html tag that makes using tab for navigating interactive elements (like links) impossible.
    Solution: remove outline:none to let the native browser focus style work. Or style it in a way that is close to the text links that goes from an solid underline to a dotted underline.

  2. No h2 on homepage.
    Problem: There are two h1 on the home page and several h3, but no h2.
    Solution: Ingredients and Recipes should be h2 and another h1 should be before them.

Less important / cosiness issues:



  1. are vocalized as "blank"
    Problem: Several recipes use

    for line breaks but nvda on firefox vocalizes it as "blank".
    Solution: on one of the br (or all of them actually) add an aria-hidden true: <br aria-hidden="true">

  2. Double links in the list of ingredients
    Problem: When navigating with nvda + firefox (ex: https://grimgrains.com/site/black_sesame_brittle.html), the list of ingredients is vocalized two times as they are two texts inside the link. It says "link brown sugar" and "link 45g".
    Solution: put the quantity outside of the link while keeping it in

Please ask if you have any question!

404: gluten flour

In the flour page, a similar ingredient is gluten flour. However, clicking the link leads to a 404 page, and ingredients.ndtl has no entry for it.

Gluten flour listed (just before end of list):
Screenshot showing gluten flour

404 page:
gluten flour 404

[Note] Corn dumplings can be made with added turmeric

I once added around 1-2 tsp of turmeric to my dumplings when I made them (with your recipe, but using a 50/50 mix of wholewheat and plain flour) and they emerged with red centres! The turmeric was leeched out of the outer parts of each dumpling, but the middle was a beautiful red.

Unfortunately I haven't replicated this, but if I get a consistent recipe I will update these numbers and potentially open a PR.

[Breaking change] Need to remove hijiki

It has been found by the Canadian, US, and UK governments that hijiki seaweed "contains a significant level of inorganic arsenic".
Furthermore, the US government states that "consumption of hijiki seaweed would significantly increase daily dietary exposure to inorganic arsenic. Consumers are therefore advised not to eat hijiki seaweed." (emphasis mine)

I suggest that hijiki be removed from Grimgrains - this would mean a recipe would have to be modified, but I believe that that is OK given the dangers.

[technical] `href='#...'` vs. `onclick='Ø...'` vs. `href='javascript:Ø...'`

I am working on a PR (#28) for better accessibility and found that links with only onclick attributes can't be selected using the tab key, so href is probably better.
However, lots of links in Grimgrains look like this:

<a href='#${name.to_url()}' onclick="Ø('query').bang('${name}')">
...
</a>

(scripts/templates/home.js:63)

This seems redundant; having only one of the two works OK for me (but I haven't tested all links).
Perhaps it would be a good idea to switch to either

<a href='#${name.to_url()}'>
...
</a>

or

<a href="javascript:Ø('query').bang('${name}')">
...
</a>

Page jump

Enable page jump, for nutrition page, or other pages with a lot of content.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.