humhub-contrib / legal Goto Github PK

Currently, it seems that the Legal Tools module is suffering from infinite loops in some areas

Similar to humhub/twofa#29

If, in the configuration, you check e.g. "Terms and Conditions", you think you will have to check the terms page.
But because the session for Events::SESSION_KEY_LEGAL_CHECK is already checked, it doesn't happen, and you think it doesn't work.
Proposal: remove the session after configuration saving.

https://github.com/humhub-contrib/legal/blob/master/Events.php#L95 is very hacky and there is no way of adding other modules to the skip list. Also there is no information why some of those modules are even skipped here. I'am not sure whats the best way to solve this, but I'am sure there will be 100 other modules listed here in few month. We should think about in which cases we need to skip this and maybe find another way around, e.g. some kind of controller flag or maybe trigger an (non legal module) event in which other modules can prevent request abortion in such cases.

1. install legal tools module and enable it. Setting configuration of Terms and Conditions, Privacy policy.
2. Go to login page ( https:// xxxxx.com/user/auth/login ). I can see my custom theme's login page.
3. Go to see the link of Terms and conditions ( https:// xxxxx.com/legal/page/view?pageKey=terms ).
4. "BACK" with browser back button.
5. I can not see my custom theme's login page. It is humhub original page which is titled 'Join the network'.

It is strange. I think it should go back to custom theme's login page.

Resetting the approvals to the terms does not seem to trigger a 'legal update'´/reset of the approvals.

HH 1.10 beta 1

When updating the texts and triggering the legal update functionality, the users should be informed about that. A simple text (Our terms have been updated, please read & confirm...) with a link to the login should be enough.

Since Humhub 1.14, I have: Calling unknown method: humhub\modules\user\components\User::canDeleteAccount()

This is due to:
https://github.com/humhub-contrib/legal/blob/master/views/page/confirm.php#L44
and
https://github.com/humhub-contrib/legal/blob/master/views/page/update.php#L47

Yii::$app->user->canDeleteAccount() should be replaced with Yii::$app->user->getAuthClientUserService()->canDeleteAccount().

But I haven't find any mention of this on https://docs.humhub.org/docs/develop/modules-migrate#version-114

Replace existing Markdown Editor widget to administer page contents with new Richtext editor.

Hello,
when I activate this addon and want to click a link,
then it takes the IP address and not the URL that is stored.
How can this be changed?
This happens with all links from this addon.
So you can not call up the terms and conditions, imprint, etc. from outside.
Attached is a picture

From the community site

Hi, I've update Humhub with 1.5.0-beta1 and legal module don't work anymore.

The file or directory to be published does not exist: /home/www-data/forges.portes-imaginaire.org/ROOT/protected/humhub/modules/ui/form/resources

In HumHub 1.6, the legal text links are still visible on the login page, but clicking them just reloads the page. It seems like the legal texts are no longer accessible for users that are not logged in. If I login and access the system as a registered user, I can click on the links on the bottom of the page and they behave as expected.

Links in checkboxes in the registration form should open a new window.

See also: https://community.humhub.com/content/perma?id=199527

When I want to update my terms of use, I use the legal update option. However, this only works once. When I want to make an update again, the legal update does not require approval from users, it does not work.

I use the humhub(ver.1.9.1: in the setting of default language with Japanese) legal module(ver.1.2.2). And we wrote the legal module's "Terms & Conditions" using "Japanese" and "English". (Thank you for multi language function.) We set "Japanese" to the default language in the legal module settings.

By the way, an English User registering to the system and he click "Terms & Conditions" in the page. Opening the link, it displays "Japanese" terms and conditions. If my memory serves me correctly, it worked correct at humhub Ver.1.8.2, legal module ver.1.2.1.

I wondering if it were something bug about language settings.

If other similar cases are reported, how about to investigate?

Thank you.

Seems very long contents were truncated. We should migrate to LONGTEXT.

Currently, in many jurisdictions, a Cookies policy is advisable or required, and when Users view the Cookies notification button for a website, there is the possibility of putting a link to the Cookies policy. At the moment the legal module does not provide a tab for that policy, and an admin would have to put it in the privacy policy. Our privacy policy is already quite long, it would be a better UI and easier to to read to have the option of a separate Cookies Policy text in the module.

In many jurisdictions, online services are required to provide the ability to give Users and for held connected with them (with exceptions).

For example in UK a "Subject Access Request" under Freedom of Information, GDPR in Europe, and similar elsewhere.

Currently, there is no simple way for a user to make such a request, and even less of a means for an admin to provide that information easily.

The ideal way of confirming with this is to provide by default a "Download my data" button on User settings (which could be turned off in Admin settings). Other online platforms have similar functions.

(This would also assist in the event someone wishes to leave a community, close an account, or move jobs, but wishes to retain information held on them as they often have a right to.)

Original Issue: humhub/humhub#4916

Links like not parsed as HTML:

<a id="ga-opt-out" href="#!">Click here to disable tracking.</a>

Solution: Allow basic HTML in the Markdown Editor

@buddh4 Related to #2 - Do you see any chance to use the new markdown editor here? Or should we use the old markdown editor here?

Bonjour, pour les cookies peu t on y ajouter un bouton refuser ? Merci par avance.

It seems as guest user I can access the page without beeing prompted with the legal confirmation view. This could be problematic when communicating with external services.

Legal text is normally pretty large given policies and terms, but text area limits text to a certain point. how to increate word limit? I was only able to edit legal/views/admin/page.php file on line 105:

<?= $form->field($pages[$languageKey], '[' . $languageKey . ']content')->widget(MarkdownField::class, ['filesInputName' => 'PageFiles[' . $languageKey . ']', 'rows' => 20]); ?>

Increased rows to 20 but it was no use. I'm still textarea limited.

I need to develop the possibility to force users that are member of a specific group to agree Terms and Conditions for this group.

The idea is to have in the groups settings an additional tab, " Terms and Conditions":

As soon as a user is member of this group, he needs to agree to the Terms and Conditions of this group (if enabled for this group).
As long as he is not a member of this group, the Terms and Conditions of this group will not be shown to him.

Would you like me to develop this feature in this Legal module and propose a new release of it or do you prefer me to develop an external module for it ?

"Back" button not directing to where it should

Optional Feature:

Ideally: An external link should be identified as such. Ideally, this would be done by automatically adding a corresponding icon behind the link. If not possible:

• Perform check after the user clicks
• If external link, delay the opening of the external page. Instead, open Lightbox with notice "You are leaving this page and will be redirected to an external page". Automatic forwarding after 5 seconds.

Would be great if we could list in better detail about the used cookies, at the moment it just shows a message model telling the user that cookies are used without giving much detail into what cookies are used and forcing the user to accept all cookies off the bat, should show a detailed message and allow the user to accept all or only necessary cookies

The user profile sidebar is activated by this module even if there is no snippet available, which looks kind of broken:

Currently there is just a text area which is fine for basic information, but it doesn't really feel like an Imprint, my suggestion would be making the view similar to how most websites should have it setup;

HumHub Imprint used as Example

https://www.humhub.com/en/legal/imprint

I tried setting up a Privacy Policy. I liked the overall look and feel of the module.

The next time I logged in, I could not proceed to the Dashboard without agreeing to the new Privacy Policy. To make matters worse, I couldn't even access the admin pages.

For my purposes, I'd rather not force any of my users to agree or even read the Privacy Policy. I'd only want it to be available as a link.

The problem with legal pages is that they often are not read.
And with this module, when a new account is created, you just need to check that you have read the legal pages, you don't even see them if you don't click on the link.

We think it would be better to have the possibility (as an option in the settings) show theses pages in full screen after the profile creation.

I propose to develop this improvement if you agree:

In the settings, add the new option "For new account creation, show pages in full screen just after profile creation":

If checked, on line https://github.com/humhub-contrib/legal/blob/master/Events.php#L135 I will replace new RegistrationChecks(); with new RegistrationChecks(['ignorePagesCheck' => true]);

And in RegistrationChecks model, I will check if $this->ignorePagesCheck is true in the check methods (e.g. showPrivacyCheck) except showAgeCheck.